Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

letsencrypt: fix account key detection for keys created by openssl_privatekey #35534

Merged
merged 2 commits into from Jan 31, 2018
Merged

letsencrypt: fix account key detection for keys created by openssl_privatekey #35534

merged 2 commits into from Jan 31, 2018

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Fix #35496

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

letsencrypt

ANSIBLE VERSION

2.5.0

ADDITIONAL INFORMATION

A proper key type detection (based on the key's contents) would be better to implement. Since openssl_privatekey for now only supports RSA, this should at least fix the usecase where the two modules are combined.

@ansibot
Copy link
Contributor

ansibot commented Jan 31, 2018

cc @mgruener @resmo
click here for bot help

@ansibot ansibot added bugfix_pull_request community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Jan 31, 2018
@resmo
Copy link
Contributor

resmo commented Jan 31, 2018

works for me

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Jan 31, 2018
@ansibot ansibot merged commit 2c48284 into ansible:devel Jan 31, 2018
@felixfontein felixfontein mentioned this pull request Jan 31, 2018
Closed
@felixfontein felixfontein deleted the letsencrypt-fix-key-detection branch January 31, 2018 07:25
Lujeni pushed a commit to Lujeni/ansible that referenced this pull request Feb 1, 2018
@felixfontein @Lujeni
letsencrypt: fix account key detection for keys created by openssl_pr…
3eee1c4 
…ivatekey (ansible#35534)

* Fixing key detection if key was generated with openssl_privatekey.

* Fixing error formatting.
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@dagwieers dagwieers added the crypto Crypto community (ACME, openssl, letsencrypt) label Feb 7, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. crypto Crypto community (ACME, openssl, letsencrypt) module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LetsEncrypt fails to recognise Account Key
4 participants
@felixfontein @ansibot @resmo @dagwieers