Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New module: manage Amazon CloudFront origin access identities (cloud/amazon/cloudfront_origin_access_identity) #35540

Merged
merged 15 commits into from Feb 1, 2018
Merged

New module: manage Amazon CloudFront origin access identities (cloud/amazon/cloudfront_origin_access_identity) #35540

merged 15 commits into from Feb 1, 2018

Conversation

wilvk
Copy link
Contributor

@wilvk wilvk commented Jan 31, 2018

SUMMARY

As advised by @ryansb in PR #24292 this comprises the origin access identity component of the cloudfront module additions.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/amazon/cloudfront_origin_access_identity.py

ANSIBLE VERSION
  config file =
  configured module search path = [u'/Users/willvk/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/willvk/Source/gits/ansibles/ansible/lib/ansible
  executable location = /Users/willvk/Source/gits/ansibles/ansible/bin/ansible
  python version = 2.7.10 (default, Feb  6 2017, 23:53:20) [GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.34)]
ADDITIONAL INFORMATION
Migrated from #24568

@wilvk wilvk mentioned this pull request Jan 31, 2018
Closed
@wilvk
Copy link
Contributor Author

wilvk commented Jan 31, 2018

@s-hertel have migrated this PR from #24568

@ansibot
Copy link
Contributor

ansibot commented Jan 31, 2018

@wilvk this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot added merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. new_plugin This PR includes a new plugin. labels Jan 31, 2018
@ansibot ansibot removed the merge_commit This PR contains at least one merge commit. Please resolve! label Jan 31, 2018
gundalow
gundalow reviewed Jan 31, 2018
View reviewed changes
lib/ansible/modules/cloud/amazon/cloudfront_origin_access_identity.py Outdated
- boto3 >= 1.0.0
- python >= 2.6

version_added: "2.4"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version_added: "2.5"

lib/ansible/modules/cloud/amazon/cloudfront_origin_access_identity.py Outdated
options:
state:
description:
- The state of the resource. Valid states are
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

description:: If the named resource should exist.
choices:
  - present
  - absent
default: present

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

lib/ansible/modules/cloud/amazon/cloudfront_origin_access_identity.py Outdated

# create an origin access identity

- cloudfront_origin_access_identity:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use - name: and not comments, e.g.

- name: Create an origin access identity
  cloudfront_origin_access_identity:
...

lib/ansible/modules/cloud/amazon/cloudfront_origin_access_identity.py
e_tag = None
changed = False

module = AnsibleAWSModule(argument_spec=argument_spec, supports_check_mode=False)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If checkmode isn't supported please add this in the
notes: section in DOCUMENTATION

Copy link
Contributor Author

@wilvk wilvk Jan 31, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have added to documentation under notes: section. let me know if this is incorrect

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, appologies, I think this needs to be a list

@ansibot
Copy link
Contributor

ansibot commented Jan 31, 2018

@wilvk this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot added the merge_commit This PR contains at least one merge commit. Please resolve! label Jan 31, 2018
@gundalow gundalow added cloud aws and removed needs_triage Needs a first human triage before being processed. labels Jan 31, 2018
@wilvk wilvk closed this Jan 31, 2018
@wilvk wilvk reopened this Jan 31, 2018
@ansibot
Copy link
Contributor

ansibot commented Jan 31, 2018

cc @willthames
click here for bot help

@ansibot ansibot added module This issue/PR relates to a module. new_module This PR includes a new module. support:community This issue/PR relates to code supported by the Ansible community. and removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Jan 31, 2018
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Jan 31, 2018
@ansibot
Copy link
Contributor

ansibot commented Jan 31, 2018

The test ansible-test sanity --test ansible-doc --python 2.6 [?] failed with the following error:

lib/ansible/modules/cloud/amazon/cloudfront_origin_access_identity.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.7 [?] failed with the following error:

lib/ansible/modules/cloud/amazon/cloudfront_origin_access_identity.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [?] failed with the following error:

lib/ansible/modules/cloud/amazon/cloudfront_origin_access_identity.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [?] failed with the following error:

lib/ansible/modules/cloud/amazon/cloudfront_origin_access_identity.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [?] failed with the following error:

lib/ansible/modules/cloud/amazon/cloudfront_origin_access_identity.py:0:0: has a documentation error formatting or is missing documentation.

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Jan 31, 2018
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Jan 31, 2018
@ansibot
Copy link
Contributor

ansibot commented Jan 31, 2018

The test ansible-test sanity --test validate-modules [?] failed with the following errors:

lib/ansible/modules/cloud/amazon/cloudfront_origin_access_identity.py:0:0: E319 RETURN.cloud_front_origin_access_identity_config.id: extra keys not allowed @ data['id']. Got {'description': 'a unique identifier of the oai', 'returned': 'always', 'type': 'string'}
lib/ansible/modules/cloud/amazon/cloudfront_origin_access_identity.py:0:0: E319 RETURN.cloud_front_origin_access_identity_config.s3_canonical_user_id: extra keys not allowed @ data['s3_canonical_user_id']. Got {'description': 'the cannonical user id of the user who created the oai', 'returned': 'always', 'type': 'string'}

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Jan 31, 2018
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Feb 1, 2018
@wilvk
Copy link
Contributor Author

wilvk commented Feb 1, 2018

@ryansb @s-hertel @gundalow thanks for your help with this PR. Looks like the tests are passing now.

@ansibot
Copy link
Contributor

ansibot commented Feb 1, 2018

@Constantin007 @Constantin07 @Deepakkothandan @Etherdaemon @Java1Guy @Lujeni @Madhura-CSI @MichaelBaydoun @Sodki @adq @akazakov @alachaum @amir343 @anryko @bekelchik @bpennypacker @brandond @carsongee @defunctio @dkhenry @fiunchinho @fivethreeo @garethr @gunzy83 @gurumaia @hsingh @hyperized @iiibrad @infectsoldier @j-carl @jarv @Java1Guy @jimbydamonk @jmenga @joelthompson @jonhadfield @jonmer85 @joshsouza @jsdalton @jsmartin @kaczynskid @leedm777 @linuxdynasty @loia @lwade @MichaelBaydoun @michaeljs1990 @minichate @mjschultz @mmochan @nadirollo @nand0p @naslanidis @nickball @orthanc @piontas @pjodouin @prasadkatti @psykotox @pwnall @raags @rickmendes @roadmapper @ryansydnor @scicoin-project @scottanderson42 @shepdelacreme @silviud @steynovich @tastychutney @tedder @tgerla @timmahoney @tombamford @tsiganenok @viper233 @whiter @wimnat @zacblazic @zbal @zeekin @zimbatm

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 1, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Feb 1, 2018
@s-hertel s-hertel merged commit e8d8c5b into ansible:devel Feb 1, 2018
@s-hertel
Copy link
Contributor

s-hertel commented Feb 1, 2018

Thanks @wilvk for all the time you've spent on these modules!

Lujeni pushed a commit to Lujeni/ansible that referenced this pull request Feb 1, 2018
@wilvk @Lujeni
New module: manage Amazon CloudFront origin access identities (cloud/…
20b2657 
…amazon/cloudfront_origin_access_identity) (ansible#35540)
@wilvk wilvk deleted the cf_origin_access_identity branch February 1, 2018 19:49
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow left review comments

@ryansb ryansb ryansb approved these changes

@s-hertel s-hertel s-hertel approved these changes

Assignees
No one assigned
Labels
aws cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wilvk @ansibot @s-hertel @ryansb @gundalow