Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix connection gets overridden by network_cli for transport nxapi,eapi net_* modules #35590

Merged
merged 2 commits into from
Feb 8, 2018
Merged

fix connection gets overridden by network_cli for transport nxapi,eapi net_* modules #35590

merged 2 commits into from
Feb 8, 2018

Conversation

trishnaguha
Copy link
Member

@trishnaguha trishnaguha commented Feb 1, 2018 •
edited

Signed-off-by: Trishna Guha trishnaguha17@gmail.com

SUMMARY
  • Fix connection getting overridden by network_cli for transport nxapi, eapi for net_* modules. Should be connection local.
  • Define transport based provider functions in individual action plugins.

devel 48ecbb8

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/action/net_base.py
plugins/action/eos.py
plugins/action/nxos.py

ANSIBLE VERSION
stable-2.4

@trishnaguha trishnaguha added the networking Network category label Feb 1, 2018
@ansibot
Copy link
Contributor

ansibot commented Feb 1, 2018

cc @Qalthos @ganeshrn @gundalow @kedarX @privateip @rcarrillocruz
click here for bot help

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 backport This PR does not target the devel branch. bugfix_pull_request needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Feb 1, 2018
@trishnaguha trishnaguha added this to Nice to have in 2.4.x Blocker List Feb 1, 2018
@trishnaguha trishnaguha removed the needs_triage Needs a first human triage before being processed. label Feb 1, 2018
@trishnaguha trishnaguha added this to the 2.4.0 milestone Feb 1, 2018
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Feb 1, 2018
@ansible ansible deleted a comment from ansibot Feb 1, 2018
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Feb 1, 2018
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 7, 2018
@trishnaguha
fix connection gets overridden by network_cli for transport nxapi,eap…
ee384df 
…i net_* modules

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@trishnaguha
pep8 fix
84a32ca 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@ansibot ansibot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 8, 2018
@trishnaguha trishnaguha merged commit 3c4d6a2 into ansible:stable-2.4 Feb 8, 2018
@trishnaguha trishnaguha deleted the stable-2.4 branch February 8, 2018 13:21
@trishnaguha trishnaguha moved this from Nice to have to Done in 2.4.4 in 2.4.x Blocker List Feb 8, 2018
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

@ganeshrn ganeshrn ganeshrn approved these changes

@privateip privateip Awaiting requested review from privateip

Assignees
No one assigned
Labels
affects_2.4 This issue/PR affects Ansible v2.4 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cisco Cisco technologies networking Network category nxos Cisco NXOS community support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
2.4.x Blocker List
Done in 2.4.4
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@trishnaguha @ansibot @gundalow @ganeshrn @dagwieers