Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMware: Deprecate vsphere_guest module #35648

Merged
merged 1 commit into from
Feb 2, 2018
Merged

VMware: Deprecate vsphere_guest module #35648

merged 1 commit into from
Feb 2, 2018

Conversation

Akasurde
Copy link
Member

@Akasurde Akasurde commented Feb 2, 2018 •
edited

SUMMARY

This change deprecates vsphere_guest in favor of vmware_guest and other
related modules.

The major reasons behind deprecation are -

  • Pysphere - Unofficial Python bindings of vCenter deprecated in the year 2013.
  • VMware provides official Python bindings for vCenter, which is used in vmware_guest.
  • vcsim - simulator used in integration testing of vmware module, does not support PySphere
    APIs, which makes it more difficult to test vsphere_guest.

Please see deprecation plan

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/vmware/vsphere_guest.py
CHANGELOG.md

ANSIBLE VERSION
2.5devel

@jctanner
Copy link
Contributor

jctanner commented Feb 2, 2018

shipit ASAP

@ansibot
Copy link
Contributor

ansibot commented Feb 2, 2018

cc @Akasurde @dagwieers @dav1x @nerzhul @rhoop
click here for bot help

@ansibot ansibot added cloud docs_pull_request module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. vmware VMware community labels Feb 2, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed shipit This PR is ready to be merged by Core labels Feb 2, 2018
@ansibot
Copy link
Contributor

ansibot commented Feb 2, 2018

The test ansible-test sanity --test validate-modules [?] failed with the following error:

lib/ansible/modules/cloud/vmware/vsphere_guest.py:0:0: E305 DOCUMENTATION.deprecated: extra keys not allowed @ data['deprecated']. Got {'removed_in': '2.9', 'why': "Replaced by M(vmware_guest) module. Also, 'Pysphere' is deprecated in favor of VMware's Official Python bindings - 'Pyvmomi'.", 'alternative': 'Use M(vmware_guest) and other vmware guest related modules instead.'}

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Feb 2, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 2, 2018
gundalow
gundalow reviewed Feb 2, 2018
View reviewed changes
Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a line in http://docs.ansible.com/ansible/devel/porting_guide_2.5.html#deprecation-notices as well

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Feb 2, 2018
@Akasurde
VMware: Deprecate vsphere_guest module
0433e93 
This change deprecates vsphere_guest in favor of vmware_guest and other
related modules.

The major reasons behind deprecation are -

- Pysphere - Unofficial Python bindings of vCenter deprecated in the year 2013.
- VMware provides official Python bindings for vCenter, which is used in vmware_guest.
- vcsim - simulator used in integration testing of vmware module does not support PySphere
  APIs, which makes it more difficult to test vsphere_guest.

Please see [deprecation plan](https://github.com/ansible/community/wiki/VMware%3A-vsphere_guest_deprecation)

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansibot ansibot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 2, 2018
@ansibot ansibot added the core_review In order to be merged, this PR must follow the core review workflow. label Feb 2, 2018
@Akasurde Akasurde merged commit d7d9e40 into ansible:devel Feb 2, 2018
@Akasurde
Copy link
Member Author

Akasurde commented Feb 2, 2018

@gundalow @jctanner Thanks for review.

@Akasurde Akasurde deleted the vsphere_guest_deprecate branch February 2, 2018 14:34
@ansibot ansibot added docs This issue/PR relates to or includes documentation. and removed docs_pull_request labels Mar 4, 2018
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

Assignees
No one assigned
Labels
cloud core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Akasurde @jctanner @ansibot @gundalow