Update examples in modules/commands to use proper YAML syntax. #35692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
core_review
Akasurde
removed
the
needs_triage
bcoca
reviewed
Feb 8, 2018
| @@ -74,7 +74,8 @@ | |||
| register: mymotd | |||
|
|
|||
| - name: Run the command if the specified file does not exist. | |||
| command: /usr/bin/make_database.sh arg1 arg2 creates=/path/to/database | |||
| command: /usr/bin/make_database.sh arg1 arg2 | |||
| creates: /path/to/database | |||
There was a problem hiding this comment.
It passes ansible --syntax-check?
---
- hosts: all
tasks:
- name: Run the command if the specified file does not exist.
command: /usr/bin/make_database.sh arg1 arg2
creates: /path/to/database
ANSIBLE VERSION
ansible 2.4.2.0
config file = /Users/jsmith39/src/wvu/ansible/ansible.cfg
configured module search path = [u'/Users/jsmith39/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
ansible python module location = /usr/local/lib/python2.7/site-packages/ansible
executable location = /usr/local/bin/ansible
python version = 2.7.14 (default, Jan 9 2018, 14:55:52) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.39.2)]
There was a problem hiding this comment.
Update - I do see that the syntax check does print a warning about an unknown attribute now.
|
Updated to fix the error. |
ansibot
added
the
stale_ci
ansibot
added
docs
gothicx
pushed a commit
to gothicx/ansible
that referenced
this pull request
Jun 9, 2018
…le#35692) * Update examples to use proper YAML syntax. * Fix syntax error.
jacum
pushed a commit
to jacum/ansible
that referenced
this pull request
Jun 26, 2018
…le#35692) * Update examples to use proper YAML syntax. * Fix syntax error.
ilicmilan
pushed a commit
to ilicmilan/ansible
that referenced
this pull request
Nov 7, 2018
…le#35692) * Update examples to use proper YAML syntax. * Fix syntax error.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Update examples in the modules/commands/*.py files to use proper YAML syntax instead of item= syntax.
ISSUE TYPE
COMPONENT NAME
commands/*
ADDITIONAL INFORMATION
I have created several similar PRs for the docs/docsite part of the tree. If there is interest in similar changes to the examples for other modules let me know and I'll update those and submit PRs for eah module as well.