contrib(inventory): fix Scaleway inventory used w/env variable token #35701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to authenticate with the Scaleway API for the contrib dynamic inventory Scaleway the environment variable SCALEWAY_TOKEN was read only if a value was set in the configuration .ini file. This PR fixes that allowing to read only the environment variable without needing to set a token in the configuration file. Closes ansible#35693
ansibot
added
bugfix_pull_request
c:inventory/contrib_script
inventory
|
shipit |
gundalow
approved these changes
Feb 5, 2018
|
Merged into |
|
Thanks both of you |
ansibot
added
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In order to authenticate with the Scaleway API for the contrib dynamic
inventory Scaleway the environment variable SCALEWAY_TOKEN was read
only if a value was set in the configuration .ini file.
This PR fixes that allowing to read only the environment variable
without needing to set a token in the configuration file.
Fixes #35693
ISSUE TYPE
COMPONENT NAME
contrib/inventory/scaleway