Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nxos_vpc_interface peer_link idempotence #35737

Merged
merged 2 commits into from Feb 7, 2018
Merged

fix nxos_vpc_interface peer_link idempotence #35737

merged 2 commits into from Feb 7, 2018
+49 −7

Conversation

saichint
Copy link
Contributor

@saichint saichint commented Feb 5, 2018 •
edited

SUMMARY

Fixes #35736

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

nxos_vpc_interface

ANSIBLE VERSION
ansible 2.5.0 (devel 788010d0f0) last updated 2018/01/08 11:49:21 (GMT -400)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /root/agents-ci/ansible/lib/ansible
  executable location = /root/agents-ci/ansible/bin/ansible
  python version = 2.7.6 (default, Oct 26 2016, 20:30:19) [GCC 4.8.4]
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Feb 5, 2018

cc @GGabriele @jedelman8 @kedarX @mikewiebe @privateip @rahushen @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added bugfix_pull_request core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels Feb 5, 2018
@trishnaguha trishnaguha self-assigned this Feb 6, 2018
@trishnaguha trishnaguha removed the needs_triage Needs a first human triage before being processed. label Feb 6, 2018
@trishnaguha trishnaguha added this to the 2.5.0 milestone Feb 6, 2018
trishnaguha
trishnaguha suggested changes Feb 6, 2018
View reviewed changes
lib/ansible/modules/network/nxos/nxos_vpc_interface.py Outdated
commands.append('no vpc peer-link')
commands.insert(0, 'interface port-channel{0}'.format(portchannel))

elif delta.get('peer-link') or not existing.get('vpc'):
elif delta.get('peer-link') and existing.get('peer-link') is not True:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please modify this to elif delta.get('peer-link') and not existing.get('peer-link'):

lib/ansible/modules/network/nxos/nxos_vpc_interface.py Outdated
@@ -194,11 +194,14 @@ def get_commands_to_config_vpc_interface(portchannel, delta, config_value, exist
commands = []

if delta.get('peer-link') is False and existing.get('peer-link') is True:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modify this one as well? if not delta.get('peer-link') and existing.get('peer-link'):

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Feb 6, 2018
@trishnaguha
Copy link
Member

@saichint please push the requested change and we are good to merge after that.

@saichint
Copy link
Contributor Author

saichint commented Feb 6, 2018

Made changes and pushed

@trishnaguha trishnaguha merged commit c9e0ce1 into ansible:devel Feb 7, 2018
@saichint saichint deleted the vpc branch February 7, 2018 22:01
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trishnaguha trishnaguha trishnaguha approved these changes

Assignees

@trishnaguha trishnaguha

Labels
bug This issue/PR relates to a bug. cisco Cisco technologies module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

nxos_vpc_interface peer_link is not idempotent
4 participants
@saichint @ansibot @trishnaguha @dagwieers