-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Homebrew Cask: Multiple updates #35759
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
bugfix_pull_request
community_review
In order to be merged, this PR must follow the community review workflow.
module
This issue/PR relates to a module.
needs_triage
Needs a first human triage before being processed.
owner_pr
This PR is made by the module's maintainer.
support:community
This issue/PR relates to code supported by the Ansible community.
labels
Feb 6, 2018
danieljaouen
force-pushed
the
homebrew_cask
branch
from
February 6, 2018 05:08
2530555
to
f6675ac
Compare
The test
|
ansibot
added
ci_verified
Changes made in this PR are causing tests to fail.
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
and removed
community_review
In order to be merged, this PR must follow the community review workflow.
owner_pr
This PR is made by the module's maintainer.
labels
Feb 6, 2018
danieljaouen
force-pushed
the
homebrew_cask
branch
from
February 6, 2018 05:22
f6675ac
to
71b5883
Compare
ansibot
removed
the
ci_verified
Changes made in this PR are causing tests to fail.
label
Feb 6, 2018
danieljaouen
force-pushed
the
homebrew_cask
branch
from
February 6, 2018 05:26
71b5883
to
ab96b89
Compare
The test
|
danieljaouen
force-pushed
the
homebrew_cask
branch
from
February 6, 2018 06:00
ab96b89
to
fa14b71
Compare
ansibot
removed
the
ci_verified
Changes made in this PR are causing tests to fail.
label
Feb 6, 2018
The test
|
danieljaouen
force-pushed
the
homebrew_cask
branch
from
February 6, 2018 06:15
fa14b71
to
bf67f3b
Compare
ansibot
removed
the
ci_verified
Changes made in this PR are causing tests to fail.
label
Feb 6, 2018
danieljaouen
force-pushed
the
homebrew_cask
branch
from
February 6, 2018 06:22
bf67f3b
to
cbe14a8
Compare
ansibot
added
community_review
In order to be merged, this PR must follow the community review workflow.
owner_pr
This PR is made by the module's maintainer.
and removed
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
labels
Feb 6, 2018
danieljaouen
force-pushed
the
homebrew_cask
branch
2 times, most recently
from
February 6, 2018 06:58
638ae7c
to
df529e2
Compare
danieljaouen
force-pushed
the
homebrew_cask
branch
from
February 6, 2018 07:00
df529e2
to
9f83795
Compare
danieljaouen
force-pushed
the
homebrew_cask
branch
from
February 6, 2018 07:21
9f83795
to
e6f5f18
Compare
samdoran
removed
the
needs_triage
Needs a first human triage before being processed.
label
Feb 8, 2018
ansibot
added
bug
This issue/PR relates to a bug.
and removed
bugfix_pull_request
labels
Mar 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
bug
This issue/PR relates to a bug.
community_review
In order to be merged, this PR must follow the community review workflow.
macos
macOS community
module
This issue/PR relates to a module.
owner_pr
This PR is made by the module's maintainer.
support:community
This issue/PR relates to code supported by the Ansible community.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes multiple issues with the Homebrew Cask module (including #33975 and #34696).
ISSUE TYPE
COMPONENT NAME
lib/ansible/modules/packaging/os/homebrew_cask.py
ANSIBLE VERSION
ADDITIONAL INFORMATION
N/A