Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homebrew Cask: Multiple updates #35759

Merged
merged 1 commit into from
Feb 8, 2018
Merged

Conversation

danieljaouen
Copy link
Contributor

SUMMARY

Fixes multiple issues with the Homebrew Cask module (including #33975 and #34696).

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/packaging/os/homebrew_cask.py

ANSIBLE VERSION
ansible 2.5.0 (homebrew 376af3274b) last updated 2018/01/14 03:55:27 (GMT -400)
  config file = /Users/dan/.ansible.cfg
  configured module search path = ['/Users/dan/src/ansible/library']
  ansible python module location = /Users/dan/src/ansible/lib/ansible
  executable location = /Users/dan/src/ansible/bin/ansible
  python version = 3.6.3 (default, Oct 21 2017, 11:37:52) [GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.42.1)]
ADDITIONAL INFORMATION

N/A

@ansibot
Copy link
Contributor

ansibot commented Feb 6, 2018

@ansibot ansibot added bugfix_pull_request community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Feb 6, 2018
@ansibot
Copy link
Contributor

ansibot commented Feb 6, 2018

The test ansible-test sanity --test validate-modules [?] failed with the following errors:

lib/ansible/modules/packaging/os/homebrew_cask.py:0:0: E322 "upgrade" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/packaging/os/homebrew_cask.py:0:0: E322 "upgrade_all" is listed in the argument_spec, but not documented in the module

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. owner_pr This PR is made by the module's maintainer. labels Feb 6, 2018
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Feb 6, 2018
@ansibot
Copy link
Contributor

ansibot commented Feb 6, 2018

The test ansible-test sanity --test validate-modules [?] failed with the following error:

lib/ansible/modules/packaging/os/homebrew_cask.py:0:0: E322 "upgrade" is listed in the argument_spec, but not documented in the module

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Feb 6, 2018
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Feb 6, 2018
@ansibot
Copy link
Contributor

ansibot commented Feb 6, 2018

The test ansible-test sanity --test validate-modules [?] failed with the following errors:

lib/ansible/modules/packaging/os/homebrew_cask.py:0:0: E322 "upgrade" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/packaging/os/homebrew_cask.py:0:0: E322 "upgrade_all" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/packaging/os/homebrew_cask.py:0:0: E323 "upgrade_all/upgrade" is listed in DOCUMENTATION.options, but not accepted by the module

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Feb 6, 2018
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Feb 6, 2018
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. owner_pr This PR is made by the module's maintainer. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 6, 2018
@danieljaouen danieljaouen force-pushed the homebrew_cask branch 2 times, most recently from 638ae7c to df529e2 Compare February 6, 2018 06:58
@samdoran samdoran merged commit 33cbbe0 into ansible:devel Feb 8, 2018
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Feb 8, 2018
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@dagwieers dagwieers added the macos macOS community label Jan 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. macos macOS community module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants