Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMware: datastore selection #35812

Merged
merged 1 commit into from Aug 9, 2018
Merged

VMware: datastore selection #35812

merged 1 commit into from Aug 9, 2018

Conversation

mbusbee
Copy link
Contributor

@mbusbee mbusbee commented Feb 6, 2018 •
edited by Akasurde

SUMMARY

This fix adds additional parameter 'datastore'. This parameter
provides a flexibility to specify custom datastore or datastore cluster
to deploy new virtual machine from template (which is located in different
datastore or datastore cluster from virtual machine's datastore or datastore
cluster).

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/vmware/vmware_guest.py

ANSIBLE VERSION
2.6devel

@ansibot
Copy link
Contributor

ansibot commented Feb 6, 2018

cc @Akasurde @Akasurde @dagwieers @dav1x @jctanner @nerzhul @pdellaert
click here for bot help

@ansibot ansibot added cloud feature_pull_request module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community labels Feb 6, 2018
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Feb 8, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 16, 2018
@Akasurde Akasurde force-pushed the datastore_fix branch 2 times, most recently from f2fa6d4 to b5239e9 Compare February 27, 2018 04:54
@ansibot ansibot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Feb 27, 2018
@Akasurde
Copy link
Member

@pdellaert @tchernomax Could you please review this ?

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 27, 2018
This was referenced Feb 27, 2018
Closed
Closed
pdellaert
pdellaert reviewed Feb 27, 2018
View reviewed changes
lib/ansible/modules/cloud/vmware/vmware_guest.py
datastore:
description:
- Specify datastore or datastore cluster to provision virtual machine.
- 'This will take precendence over "disk.datastore" parameter.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that setting the datastore for each disk separately will no longer work?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, specifying separate datastore in disk is not working either.

ansible/lib/ansible/modules/cloud/vmware/vmware_guest.py

Line 1442 in 87d6bda

# TODO: This is already handled by the relocation spec,

@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 2, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 10, 2018
@Akasurde
Copy link
Member

Akasurde commented May 2, 2018

@dericcrago Could you please review this ?

@ansibot
Copy link
Contributor

ansibot commented May 2, 2018

cc @warthog9
click here for bot help

@dericcrago
Copy link
Contributor

I don't see any tests in this PR, are there already tests for this functionality?

@Akasurde
Copy link
Member

Akasurde commented May 2, 2018

@dericcrago This requires creating a template in different datastore or datastore cluster. VCSIM does not support template at this moment. So no testcase for this scenario. Let me know if you have any idea or suggestion to test this feature.

@Akasurde Akasurde mentioned this pull request May 12, 2018
Closed
@ansibot ansibot added the affects_2.6 This issue/PR affects Ansible v2.6 label May 18, 2018
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels May 26, 2018
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 2, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 10, 2018
@corbinstuard
Copy link

Is this change still WIP? It is very much desired.

@Akasurde
Copy link
Member

@corbinstuard I am waiting for the reviews. I would really appreciate if you or someone else could test this and provide feedback. Thanks.

@moshloop
Copy link

I have tested and confirmed that this works on vSphere 6.5 cloning into a different cluster & datastore.

@joerussbowman
Copy link

I think I'm waiting on this as well, unless there is another way to deploy a template to another host/datastore? I've tried specifying esxi_hostname and a datastore on the template disk definition. Is this still being reviewed?

@moshloop
Copy link

moshloop commented Aug 9, 2018

@Akasurde what else is required to get this merged?

@Akasurde
VMware: datastore selection
d6a3483 
This fix adds additional parameter 'datastore'. This parameter
provides a flexibility to specify custom datastore or datastore cluster
to deploy new virtual machine from template (which is located in different
datastore or datastore cluster from virtual machine's datastore or datastore
cluster).

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 9, 2018
@Akasurde Akasurde merged commit b851321 into ansible:devel Aug 9, 2018
@Akasurde Akasurde deleted the datastore_fix branch August 9, 2018 17:20
alikins added a commit that referenced this pull request Aug 10, 2018
@alikins
Merge branch 'devel' into mazer_role_loader
1431900 
* devel: (30 commits)
  Prevent data being truncated over persistent connection socket (#43885)
  Fix eos_command integration test failures (#43922)
  Update iosxr cliconf plugin (#43837)
  win_domain modules: ensure Netlogon service is still running after promotion (#43703)
  openvswitch_db : Handle column value conversion and idempotency in no_key case (#43869)
  Fix typo
  Fix spelling of ansbile to ansible (#43898)
  added platform guides for NOS and VOSS (#43854)
  Fix download URL for yum integration test.
  New module for managing EMC VNX Block storage (#42945)
  Docker integration tests: factorize setup (#42306)
  VMware: datastore selection (#35812)
  Remove unnecessary features from cli_command (#43829)
  [doc] import_role: mention version from which behavior changed and fix some typos (#43843)
  Add source interface and use-vrf features (#43418)
  Fix unreferenced msg from vmware_host (#43872)
  set supports_generate_diff to False vyos (#43873)
  add group_by_os_family in azure dynamic inventory (#40702)
  ansible-test: Create public key creating Windows targets (#43760)
  azure_rm_loadbalancer_facts.py: list() takes at least 2 arguments fix (#29046) (#29050)
  ...
@tomtastic
Copy link
Contributor

Can this be backported to 2.4, I hit #35012 this morning with Ansible 2.4.2.0

@Akasurde
Copy link
Member

Akasurde commented Sep 5, 2018

@tomtastic I am afraid that 2.4 is only open for security fixes and we can not backport this under that criteria. I would recommend you to update Ansible to 2.7. Thanks.

This was referenced Oct 28, 2018
Closed
Closed
Closed
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Akasurde Akasurde Akasurde left review comments

@pdellaert pdellaert pdellaert left review comments

Assignees
No one assigned
Labels
affects_2.6 This issue/PR affects Ansible v2.6 cloud community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@mbusbee @ansibot @Akasurde @dericcrago @corbinstuard @moshloop @joerussbowman @tomtastic @pdellaert @samdoran