New module: digital_ocean_size_facts #35898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
cloud
core_review
Akasurde
removed
the
needs_triage
|
@pmarques Could you please review this ? |
ansibot
added
needs_rebase
BondAnthony
suggested changes
Feb 17, 2018
| def core(module): | ||
| rest = DigitalOceanHelper(module) | ||
|
|
||
| # Check if api_token is valid or not |
There was a problem hiding this comment.
We should no longer need this token validation if PR #36352 is merged before.
|
|
||
|
|
||
| def main(): | ||
| module = AnsibleModule( |
There was a problem hiding this comment.
Probably want to change this to your standard DO argument spec. This will handle testing the oauth_token and finding the token in the users environment.
argument_spec = DigitalOceanHelper.digital_ocean_argument_spec()
module = AnsibleModule(argument_spec=argument_spec)
67da4ea
to
1b9f31b
Compare
ansibot
removed
needs_rebase
BondAnthony
suggested changes
Feb 28, 2018
| module: digital_ocean_size_facts | ||
| short_description: Gather facts about DigitalOcean Sizes | ||
| description: | ||
| - This module can be used to gather facts about sizes. |
There was a problem hiding this comment.
Could we included the word Droplet Sizes? That will clear up any confusion on what sizes.
|
|
||
| RETURN = ''' | ||
| data: | ||
| description: DigitalOcean size facts |
There was a problem hiding this comment.
DigitalOcean droplet size facts would be clear to the end user.
|
Tested the module and it works perfectly, please address the size comments in the documentation. |
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Akasurde
force-pushed
the
do_size_facts
branch
from
1b9f31b
to
734e896
Compare
|
Thank you! shipit |
ansibot
added
shipit
|
@BondAnthony Thanks for review and testing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com
ISSUE TYPE
COMPONENT NAME
lib/ansible/modules/cloud/digital_ocean/digital_ocean_size_facts.py
ANSIBLE VERSION