New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set play context on stdout callback plugin #35910
Conversation
The loop on self._callback_plugins does not include the stdout callback, so the stdout_callback never has set_play_context called.
Spot this problem too. I think the better way to fix this is to concatenate arrays similar to def send_callback(self, method_name, *args, **kwargs):
for callback_plugin in [self._stdout_callback] + self._callback_plugins: |
@diafour I'd also suggest using |
Um.. and why not to use |
@diafour it was just my addition to your snippet, I'm not discouraging your approach, just augmenting it. |
@webknjaz got that ;) I was augmented too. |
rebuild_merge |
The loop on self._callback_plugins does not include the stdout callback, so the stdout_callback never has set_play_context called.
SUMMARY
The loop on self._callback_plugins does not include the stdout callback,
so the stdout_callback never has set_play_context called.
ISSUE TYPE