New module: digital_ocean_region_facts #35911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
cloud
core_review
Akasurde
removed
the
needs_triage
|
@pmarques Could you please review this ? |
ansibot
added
needs_rebase
|
LGTM Tested module with Ansible version 2.6 |
ansibot
added
the
stale_ci
pmarques
reviewed
Feb 18, 2018
| author: "Abhijeet Kasurde (@akasurde)" | ||
| version_added: "2.5" | ||
| options: | ||
| oauth_token: |
There was a problem hiding this comment.
Use documentation fragment
| description: DigitalOcean regions facts | ||
| returned: success | ||
| type: list | ||
| sample: [ |
| # Check if api_token is valid or not | ||
| response = rest.get('account') | ||
| if response.status_code == 401: | ||
| module.fail_json(msg='Failed to login using API token, please verify validity of API token.') |
There was a problem hiding this comment.
Remove this because is already inside DO utils
| break | ||
| page += 1 | ||
| regions.extend(response.json["regions"]) | ||
| has_next = "pages" in response.json["links"] and "next" in response.json["links"]["pages"] |
There was a problem hiding this comment.
If PR #36004 is merged, can we update this to use get_paginated_data?
There was a problem hiding this comment.
Yes. This is old module. And 36004 got merged before this. I will update rest of them to use pagination.
| def main(): | ||
| module = AnsibleModule( | ||
| argument_spec=dict( | ||
| oauth_token=dict(aliases=['DO_API_TOKEN', 'DO_API_KEY', 'DO_OAUTH_TOKEN'], |
There was a problem hiding this comment.
Use digital_ocean_argument_spec form DO utils.
Akasurde
force-pushed
the
do_region_facts
branch
from
0538bfc
to
0a23a2a
Compare
ansibot
added
test
Akasurde
force-pushed
the
do_region_facts
branch
from
0a23a2a
to
1fe366d
Compare
ansibot
removed
needs_rebase
|
@BondAnthony @Akasurde @alukovenko @harneksidhu @kontrafiktion @mgregson @pmarques @zbal As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add |
ansibot
added
community_review
|
LTGM Thanks @Akasurde |
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Akasurde
force-pushed
the
do_region_facts
branch
from
1fe366d
to
8152825
Compare
|
@BondAnthony @pmarques Thanks for review. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com
ISSUE TYPE
COMPONENT NAME
lib/ansible/modules/cloud/digital_ocean/digital_ocean_region_facts.py
ANSIBLE VERSION