Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

networking fix cherry-pick #35936

Merged
merged 4 commits into from
Feb 9, 2018
Merged

networking fix cherry-pick #35936

merged 4 commits into from
Feb 9, 2018

Conversation

trishnaguha
Copy link
Member

SUMMARY

5a198e1
73650cf
b30f3b9

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

modules/network/{eos,ios}
test/integration/targets/nxos_bgp

ANSIBLE VERSION
2.4

mikewiebe and others added 4 commits February 9, 2018 10:55
@mikewiebe @trishnaguha
Add minor conditional checks to nxos_bgp sanity test (ansible#35476)
12e8c57 
* Add minor conditional checks to nxos_bgp sanity test

* Make ansibot happy

(cherry picked from commit 5a198e1)
@jmighion @trishnaguha
fixing the removed_in_version to 2.6. (ansible#35853)
8d10778 
(cherry picked from commit 73650cf)
@trishnaguha
fix eos_config second-level indent idempotece (ansible#35588)
2c56740 
* fix eos_config second-level indent idempotece

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* address ganeshrn's comment - update doc

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit b30f3b9)
@trishnaguha
update CHANGELOG
c310e04 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@ansibot
Copy link
Contributor

ansibot commented Feb 9, 2018

cc @GGabriele @jedelman8 @kedarX @mikewiebe @privateip @rahushen @rcarrillocruz
click here for bot help

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 backport This PR does not target the devel branch. bugfix_pull_request core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels Feb 9, 2018
@trishnaguha trishnaguha removed the needs_triage Needs a first human triage before being processed. label Feb 9, 2018
@trishnaguha trishnaguha merged commit 7c4e343 into ansible:stable-2.4 Feb 9, 2018
@trishnaguha trishnaguha deleted the stable-2.4 branch February 9, 2018 06:07
@trishnaguha trishnaguha added this to Done in 2.4.4 in 2.4.x Blocker List Feb 9, 2018
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.4 This issue/PR affects Ansible v2.4 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
No open projects
2.4.x Blocker List
Done in 2.4.4
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@trishnaguha @ansibot @dagwieers @mikewiebe @jmighion