Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win_domain_controller: optionally add -ReadOnlyReplica if true #36017

Merged
merged 1 commit into from Feb 14, 2018
Merged

win_domain_controller: optionally add -ReadOnlyReplica if true #36017

merged 1 commit into from Feb 14, 2018

Conversation

jborean93
Copy link
Contributor

SUMMARY

The -ReadOnlyReplica option being set requires the site name option where before it was not. This change updates the module to only set the read only option if it is true keeping it in line with the previous behaviour.

Fixes #35858.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_domain_controller

ANSIBLE VERSION
2.5

@jborean93 jborean93 mentioned this pull request Feb 12, 2018
Closed
@ansibot
Copy link
Contributor

ansibot commented Feb 12, 2018

cc @dagwieers @jhawkesworth @nitzmahone
click here for bot help

@ansibot ansibot added bugfix_pull_request core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community labels Feb 12, 2018
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Feb 12, 2018
@jborean93
Copy link
Contributor Author

From #35858 (comment)

This change successfully created an additional DC and a RODC. Thanks.

@jborean93 jborean93 merged commit 09d939f into ansible:devel Feb 14, 2018
@jborean93 jborean93 deleted the win_domain_controller branch February 14, 2018 20:16
jborean93 added a commit that referenced this pull request Feb 14, 2018
@jborean93
win_domain_controller: optionally add -ReadOnlyReplica if true (#36017)
25e02d1 
(cherry picked from commit 09d939f)
@jborean93
Copy link
Contributor Author

Cherry-picked back to stable-2.5 25e02d1 for the 2.5.0 release.

@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

win_domain_controller fails with required parameter error
3 participants
@jborean93 @ansibot @sivel