Acquire displayed messages from forked process

[Qalthos]

SUMMARY

Fixes #24721

Has the unfortunate side effect of passing text through Display.display() twice, so strings look like <hostname> <hostname> text to be displayed

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

ansible-connection

ANSIBLE VERSION

2.5

[gundalow]

Got an example of logs when using this with proxy?

[Qalthos]

It needs -vvvv (because that's the level that logs from the persistent process get reintroduced at). Here's the output from my testing:

task path: /home/nate/workspace/ansible/test/vyos_facts.yaml:7
<vyrtos> attempting to start connection
<vyrtos> using connection plugin network_cli
<vyrtos> local domain socket does not exist, starting it
<vyrtos> control socket path is /home/nate/.ansible/pc/04f29afd10
<vyrtos> <vyrtos> ESTABLISH CONNECTION FOR USER: nate on PORT 22 TO vyrtos
<vyrtos> <vyrtos> CONFIGURE PROXY COMMAND FOR CONNECTION: ssh -W vyrtos:22 -q bastion
<vyrtos> <vyrtos> ssh connection done, setting terminal
<vyrtos> <vyrtos> loaded terminal plugin for network_os vyos
<vyrtos> <vyrtos> loaded cliconf plugin for network_os vyos
<vyrtos> <vyrtos> firing event: on_open_shell()
<vyrtos> <vyrtos> ssh connection has completed successfully
<vyrtos> connection to remote device started successfully
<vyrtos> local domain socket listeners started successfully
<vyrtos> 
<vyrtos> local domain socket path is /home/nate/.ansible/pc/04f29afd10
Using module file /home/nate/workspace/ansible/ansible/lib/ansible/modules/network/vyos/vyos_command.py
<vyrtos> ESTABLISH LOCAL CONNECTION FOR USER: nate
<vyrtos> EXEC /bin/sh -c 'python && sleep 0'

The addition is the lines starting with <vyrtos> <vyrtos> for reasons explained earlier. I haven't actually added any logging, just exposing existing display calls. If we really want this to go to ANSIBLE_LOG as the issue claims, that could be arranged, but I figured that was a leftover from the unable to open shell days.

[gundalow]

That looks good, Thanks. Feel free to merge & CP