Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMware: Refactor vmware_vswitch #36091

Merged
merged 1 commit into from Apr 28, 2018
Merged

VMware: Refactor vmware_vswitch #36091

merged 1 commit into from Apr 28, 2018

Conversation

Akasurde
Copy link
Member

SUMMARY
  • Update documentation
  • Update logic
  • Added idempotency
  • Added Error handling

Fixes: #36030

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/vmware/vmware_vswitch.py

ANSIBLE VERSION
2.6devel

This was referenced Feb 13, 2018
Closed
Closed
@ansibot
Copy link
Contributor

ansibot commented Feb 13, 2018

cc @Akasurde @dav1x @jctanner @nerzhul
click here for bot help

@ansibot ansibot added bugfix_pull_request cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Feb 13, 2018
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. test This PR relates to tests. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 13, 2018
@gundalow gundalow removed the needs_triage Needs a first human triage before being processed. label Feb 14, 2018
@Akasurde
Copy link
Member Author

@pdellaert @tchernomax Could you please review this ?

pdellaert
pdellaert reviewed Feb 19, 2018
View reviewed changes
lib/ansible/modules/cloud/vmware/vmware_vswitch.py Outdated
self.esxi_hostname = module.params['esxi_hostname']
esxi_hostname = module.params['esxi_hostname']

hosts = get_all_objs(self.content, [vim.HostSystem])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the refactored logic of host/cluster here to simplify?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

tchernomax
tchernomax approved these changes Feb 23, 2018
View reviewed changes
Copy link
Contributor

@tchernomax tchernomax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Feb 23, 2018
@ansibot
Copy link
Contributor

ansibot commented Feb 23, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_vswitch.py:0:0: E324 Value for "default" from the argument_spec ([]) for "nics" does not match the documentation (None)

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed shipit This PR is ready to be merged by Core labels Feb 23, 2018
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 26, 2018
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 5, 2018
@Akasurde Akasurde force-pushed the vswitch_refactor branch 2 times, most recently from 3d5e5e8 to f34a8a1 Compare March 8, 2018 07:50
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Mar 16, 2018
@umrikar
Copy link

umrikar commented Mar 30, 2018

@Akasurde could you tell when this change will get merged

@Akasurde
VMware: Refactor vmware_vswitch
d51a511 
* Update documentation
* Update logic
* Added idempotency
* Added Error handling

Fixes: ansible#36030

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 28, 2018
@Akasurde Akasurde merged commit ed141f1 into ansible:devel Apr 28, 2018
@Akasurde Akasurde deleted the vswitch_refactor branch April 28, 2018 11:01
@Akasurde
Copy link
Member Author

@tchernomax @pdellaert @umrikar Thanks for the reviews.

oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 12, 2018
@Akasurde
VMware: Refactor vmware_vswitch (ansible#36091)
1d191d9 
* Update documentation
* Update logic
* Added idempotency
* Added Error handling

Fixes: ansible#36030

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
@Akasurde
VMware: Refactor vmware_vswitch (ansible#36091)
d7ebe34 
* Update documentation
* Update logic
* Added idempotency
* Added Error handling

Fixes: ansible#36030

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
@Akasurde
VMware: Refactor vmware_vswitch (ansible#36091)
bc45f10 
* Update documentation
* Update logic
* Added idempotency
* Added Error handling

Fixes: ansible#36030

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
@Akasurde
VMware: Refactor vmware_vswitch (ansible#36091)
c23ebff 
* Update documentation
* Update logic
* Added idempotency
* Added Error handling

Fixes: ansible#36030

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
@Akasurde
VMware: Refactor vmware_vswitch (ansible#36091)
8a38bfd 
* Update documentation
* Update logic
* Added idempotency
* Added Error handling

Fixes: ansible#36030

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@Akasurde @ilicmilan
VMware: Refactor vmware_vswitch (ansible#36091)
1baea2b 
* Update documentation
* Update logic
* Added idempotency
* Added Error handling

Fixes: ansible#36030

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansible ansible locked and limited conversation to collaborators Apr 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pdellaert pdellaert pdellaert left review comments

@tchernomax tchernomax tchernomax approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor vmware_vswitch is required
6 participants
@Akasurde @ansibot @umrikar @pdellaert @tchernomax @gundalow