Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation updates for zabbix_maintenance.py #36123

Merged
merged 1 commit into from Feb 22, 2018
Merged

Documentation updates for zabbix_maintenance.py #36123

merged 1 commit into from Feb 22, 2018

Conversation

richlv
Copy link
Contributor

@richlv richlv commented Feb 13, 2018

clarify that removal happens by name - while expected, it's good to be explicit

SUMMARY

be more explicit about removal

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

zabbix_maintenance

ANSIBLE VERSION

latest

@richlv
Update zabbix_maintenance.py
3362d06 
clarify that removal happens by name - while expected, it's good to be explicit
@ansibot
Copy link
Contributor

ansibot commented Feb 13, 2018

cc @abulimov @eikef
click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. docs_pull_request module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Feb 13, 2018
@sivel sivel changed the title Update zabbix_maintenance.py Documentation updates for zabbix_maintenance.py Feb 13, 2018
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Feb 13, 2018
@eikef
Copy link
Contributor

eikef commented Feb 19, 2018

shipit

@eikef
Copy link
Contributor

eikef commented Feb 19, 2018

@D3DeFi mind having a look as well? :)

@D3DeFi
Copy link
Contributor

D3DeFi commented Feb 22, 2018

It is always ok to be more specific! :)

@D3DeFi
Copy link
Contributor

D3DeFi commented Feb 22, 2018

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core automerge This PR was automatically merged by ansibot. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Feb 22, 2018
@ansibot ansibot merged commit 0e0d6cf into ansible:devel Feb 22, 2018
@richlv richlv deleted the patch-1 branch February 22, 2018 16:33
@ansibot ansibot added docs This issue/PR relates to or includes documentation. and removed docs_pull_request labels Mar 4, 2018
@dagwieers dagwieers added the zabbix Zabbix community label Jan 28, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
automerge This PR was automatically merged by ansibot. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. zabbix Zabbix community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@richlv @ansibot @eikef @D3DeFi @sivel @dagwieers