Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduces the unit test time of select bigip modules #36256

Merged
merged 1 commit into from
Feb 15, 2018
Merged

Reduces the unit test time of select bigip modules #36256

merged 1 commit into from
Feb 15, 2018

Conversation

caphrim007
Copy link
Contributor

SUMMARY

The modules in this patch include waits that need to happen to ensure
something is correctly configured on a BIG-IP. These waits were
raised as an issue in a recent ansible-testing meeting.

This patch eliminates the waits by mocking time.sleep

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

f5 modules

ANSIBLE VERSION
ansible 2.6.0
  config file = None
  configured module search path = ['/root/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python3.6/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 3.6.4 (default, Dec 21 2017, 01:35:12) [GCC 4.9.2]
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Feb 15, 2018

cc @Qalthos @ganeshrn @gundalow @kedarX @privateip @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added bugfix_pull_request needs_triage Needs a first human triage before being processed. networking Network category python3 support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 15, 2018
@caphrim007 caphrim007 force-pushed the bugfix.reduce-unit-test-time-of-bigip-tests branch 3 times, most recently from f88eafc to 293f3f3 Compare February 15, 2018 19:46
@ansibot
Copy link
Contributor

ansibot commented Feb 15, 2018

The test ansible-test sanity --test pylint [explain] failed with 1 error:

test/units/modules/network/f5/test_bigip_device_httpd.py:125:0: trailing-newlines Trailing newlines

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

test/units/modules/network/f5/test_bigip_device_httpd.py:125:1: W391 blank line at end of file

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Feb 15, 2018
@caphrim007
Reduces the unit test time of select bigip modules
5effef2 
The modules in this patch include waits that need to happen to ensure
something is correctly configured on a BIG-IP. These waits were
raised as an issue in a recent ansible-testing meeting.

This patch eliminates the waits by mocking time.sleep
@caphrim007 caphrim007 force-pushed the bugfix.reduce-unit-test-time-of-bigip-tests branch from 293f3f3 to 5effef2 Compare February 15, 2018 19:52
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Feb 15, 2018
@caphrim007
Copy link
Contributor Author

@gundalow ready for review

@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Feb 15, 2018
@gundalow gundalow removed the needs_triage Needs a first human triage before being processed. label Feb 15, 2018
@gundalow gundalow self-assigned this Feb 15, 2018
@gundalow gundalow merged commit 77fa417 into ansible:devel Feb 15, 2018
gundalow pushed a commit to gundalow/ansible that referenced this pull request Feb 15, 2018
@caphrim007 @gundalow
Reduces the unit test time of select bigip modules (ansible#36256)
b9cb2f1 
The modules in this patch include waits that need to happen to ensure
something is correctly configured on a BIG-IP. These waits were
raised as an issue in a recent ansible-testing meeting.

This patch eliminates the waits by mocking time.sleep
(cherry picked from commit 77fa417)
@alikins
Copy link
Contributor

alikins commented Feb 15, 2018

👍 ⏩ 🏎

gundalow added a commit that referenced this pull request Feb 15, 2018
@gundalow
Reduces the unit test time of select bigip modules (#36256) (#36260)
7849328 
The modules in this patch include waits that need to happen to ensure
something is correctly configured on a BIG-IP. These waits were
raised as an issue in a recent ansible-testing meeting.

This patch eliminates the waits by mocking time.sleep
(cherry picked from commit 77fa417)
@gundalow
Copy link
Contributor

Thanks
Merged into devel and cherry-picked into stable-2.5 7849328

@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@caphrim007 caphrim007 deleted the bugfix.reduce-unit-test-time-of-bigip-tests branch August 28, 2018 17:12
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

Assignees

@gundalow gundalow

Labels
bug This issue/PR relates to a bug. networking Network category python3 support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@caphrim007 @ansibot @alikins @gundalow