Fixes for the N3500 platform that uses the A8 image #36261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@trishnaguha Please prioritize this PR as these commits need to make it into 2.5 |
ansibot
added
bugfix_pull_request
core_review
mikewiebe
reviewed
Feb 15, 2018
| @@ -236,6 +236,9 @@ def main(): | |||
| cmds = get_commands(proposed, existing, state, module) | |||
|
|
|||
| if cmds: | |||
| # On N35 A8 images, some features return a yes/no prompt | |||
| # on enablement or disablement. Bypass using terminal dont-ask | |||
| cmds.insert(0, 'terminal dont-ask') | |||
There was a problem hiding this comment.
Please make sure to test these changes across our platform matrix.
ansibot
added
needs_revision
|
CI failure in unit tests: https://app.shippable.com/github/ansible/ansible/runs/54923/3/tests |
mattclay
added
the
ci_verified
|
@rahushen Thanks for the PR. Please confirm that this PR has been tested across the platforms. We are good to merge after you fix the unittest failure. |
ansibot
added
support:core
ansibot
added
core_review
trishnaguha
approved these changes
Feb 17, 2018
trishnaguha
pushed a commit
to trishnaguha/ansible
that referenced
this pull request
Feb 17, 2018
* fix nxos_l3_interface tests as n35 doesn't support ipv6 * add terminal dont-ask to nxos_feature and nxos_lldp * put interfaces in L2 mode for N35 * fix nxos_feature unit-tests (cherry picked from commit e24c547)
trishnaguha
added a commit
that referenced
this pull request
Feb 17, 2018
* Fix nxos_system tests (#36201) * Fix nxos_system tests * Add debug connection plugin info * Move sanity test under common (cherry picked from commit 5b5d246) * Fixes for the N3500 platform that uses the A8 image (#36261) * fix nxos_l3_interface tests as n35 doesn't support ipv6 * add terminal dont-ask to nxos_feature and nxos_lldp * put interfaces in L2 mode for N35 * fix nxos_feature unit-tests (cherry picked from commit e24c547)
|
cherry-picked to stable-2.5 |
ansibot
added
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Some of the newer module added in Ansible 2.5 were failing on the N35 platform. This PR addresses those failures.
ISSUE TYPE
COMPONENT NAME
ANSIBLE VERSION