Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aci_rest: Fix error handling and improve documentation #36295

Merged
merged 1 commit into from Feb 19, 2018
Merged

aci_rest: Fix error handling and improve documentation #36295

merged 1 commit into from Feb 19, 2018

Conversation

dagwieers
Copy link
Contributor

@dagwieers dagwieers commented Feb 16, 2018 •
edited

SUMMARY

This PR includes:

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

aci_rest

ANSIBLE VERSION

v2.5

@dagwieers dagwieers added the aci Cisco ACI community label Feb 16, 2018
@dagwieers dagwieers added this to the 2.5.0 milestone Feb 16, 2018
@dagwieers dagwieers added this to To Do in 2.5.x blocker list via automation Feb 16, 2018
@ansibot
Copy link
Contributor

ansibot commented Feb 16, 2018

cc @brunocalogero @dharmabumstead @jmcgill298 @schunduri
click here for bot help

@ansibot ansibot added bugfix_pull_request core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Feb 16, 2018
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. test This PR relates to tests. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. labels Feb 16, 2018
@dagwieers
aci_rest: Fix error handling and improve documentation
5b4fed1 
This PR includes:
- A fix for a recently introduced issue wrt. error handling
- Added integration tests for provoked errors
- Influence standard return values using aci library for aci_rest
- Add proxy support documentation
- Documentation update related to ansible#34175
@ansibot
Copy link
Contributor

ansibot commented Feb 19, 2018

cc @Qalthos @ganeshrn @gundalow @kedarX @privateip @rcarrillocruz @trishnaguha
click here for bot help

@dagwieers dagwieers merged commit 79d00ad into ansible:devel Feb 19, 2018
@gundalow
Copy link
Contributor

Remember these will need cherry-picking into stable-2.5 branch...

@dagwieers
Copy link
Contributor Author

Isn't that what the 2.5.0 blockers list is for ?

@nitzmahone nitzmahone moved this from To Do to Done in 2.5.x blocker list Feb 22, 2018
@ansibot ansibot added docs This issue/PR relates to or includes documentation. and removed docs_pull_request labels Mar 4, 2018
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
aci Cisco ACI community bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
No open projects
2.5.x blocker list
  
Done
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dagwieers @ansibot @gundalow