Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCP: Creating external IP Addresses #36325

Merged
merged 1 commit into from Apr 2, 2018
Merged

Conversation

rambleraptor
Copy link
Contributor

SUMMARY

Adding support for GCP Compute IP Addresses

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

gcp_compute_address

ANSIBLE VERSION
2.6
ADDITIONAL INFORMATION

This was autogenerated using Magic Modules

@ansibot
Copy link
Contributor

ansibot commented Feb 16, 2018

@ansibot ansibot added cloud community_review In order to be merged, this PR must follow the community review workflow. gce module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Feb 16, 2018
@ansibot
Copy link
Contributor

ansibot commented Feb 16, 2018

@GwenaelPellenArkeup @bennojoy @dohoangkhiem @erjohnso @GoogleCloudPlatform @nitaco @robwagner33 @supertom @walbert947

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@rambleraptor
Copy link
Contributor Author

@ryansb please take a look

@GwenaelPellenArkeup
Copy link
Contributor

Hello.

why create a new module?

gce_eip.py can create an External IP.

Best regards.

@ryansb
Copy link
Contributor

ryansb commented Feb 19, 2018

the new gcp_* series of modules are autogenerated from the new version of the GCP API, so it doesn't have the same SDK requirements and sometimes differs from the parameters accepted in the existing modules (for services that have existing modules).

The idea is to use the Magic Modules code generator to more completely cover the GCP services. Since Magic Modules is also open source, we can review the modules it generates and make sure they meet Ansible standards for docs, usability, and such.

@ryansb ryansb removed the needs_triage Needs a first human triage before being processed. label Feb 19, 2018
the same network, you can use an instance's internal IP address. To
communicate with the Internet and instances outside of the same network,
you must specify the instance's external IP address.
Internal IP addresses are ephemeral and only belong to an instance for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a paragraph break (which seems like what this line is supposed to be) make the string a new list item.

required: false
name:
description:
- Name of the resource.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to include any restrictions on the name (can it have spaces? Dashes? Umlaüts?)

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 1, 2018
@s-hertel s-hertel merged commit d129396 into ansible:devel Apr 2, 2018
ryancurrah pushed a commit to ryancurrah/ansible that referenced this pull request Apr 4, 2018
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cloud community_review In order to be merged, this PR must follow the community review workflow. gce module This issue/PR relates to a module. new_module This PR includes a new module. new_plugin This PR includes a new plugin. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants