Letsencrypt authz deactivation #36362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
community_review
Akasurde
removed
the
needs_triage
resmo
reviewed
Feb 19, 2018
| - "Authentication objects are bound to an account key and remain valid | ||
| for a certain amount of time, and can be used to issue certificates | ||
| without having to re-authenticate the domain. This can be a security | ||
| concern. " |
There was a problem hiding this comment.
Whoops. I'll fiix that in the next PR or so :)
|
code LGTM. shipit |
ansibot
added
automerge
|
Thanks for reviewing and merging! |
ansibot
added
feature
|
The whitespace is gone by now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds an option which allows to deactivate authz objects after successful or not successful certificate issuance, as explained in #36344. I've changed all direct
module.fail_jsoncalls to exceptions so that authz cleanup can be relatively reliably done in atry ... finallyconstruct. Unfortunately,fetch_url()inansible.module_utils.urlsdirectly callsmodule.fail_json, hence in these cases no cleanup will be done.Fix #36344.
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
letsencrypt
ANSIBLE VERSION