Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMware: refactor vmware_datastore_facts #36423

Merged
merged 1 commit into from
Feb 26, 2018

Conversation

Akasurde
Copy link
Member

SUMMARY

This fix adds datastore cluster details about datastore in returning
facts. Updated documentation and tests.

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME

test/integration/targets/vmware_datastore_facts/tasks/main.yml
lib/ansible/modules/cloud/vmware/vmware_datastore_facts.py

ANSIBLE VERSION
2.6devel

This fix adds datastore cluster details about datastore in returning
facts. Updated documentation and tests.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansibot
Copy link
Contributor

ansibot commented Feb 20, 2018

@ansibot ansibot added bugfix_pull_request cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. vmware VMware community labels Feb 20, 2018
@Akasurde
Copy link
Member Author

@pdellaert @tchernomax Could you please review this ?

@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Feb 20, 2018
Copy link
Contributor

@tchernomax tchernomax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Feb 23, 2018
@Akasurde Akasurde merged commit d94a1ef into ansible:devel Feb 26, 2018
@Akasurde
Copy link
Member Author

@tchernomax Thanks for review.

@Akasurde Akasurde deleted the datastore_cluster_facts branch February 26, 2018 07:53
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. vmware VMware community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants