winrm: (backport) Fix kerberos auth encoding for Python 3 #36465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jborean93
changed the title
nitzmahone
approved these changes
Feb 20, 2018
jborean93
force-pushed
the
py3-kerb-fix
branch
from
e6861cf
to
5dcbae6
Compare
ansibot
added
affects_2.4
ansibot
added
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
On Python 3, subprocess stdin should be a byte string and currently password is stored as a unicode string. This fix converts the string to bytes and uses that in the communicate process.
Was fixed in devel with 92e52ef#diff-4027b6fb84a6b8cdcd2ae5a0d348998d but because it added new features this is a manual backport for this fix.
Fixes #36255
ISSUE TYPE
COMPONENT NAME
winrm
ANSIBLE VERSION