Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACI: Various changes to module documentation and guide #36516

Merged
merged 6 commits into from
Feb 21, 2018

Conversation

dagwieers
Copy link
Contributor

@dagwieers dagwieers commented Feb 21, 2018

SUMMARY

This PR includes:

  • We moved the object class information to the notes
  • Add version information to guide chapters
  • Add generic note to modules with reference to ACI guide
  • Reference known issues in aci_rest documentation
  • Remove module_utils function docs from modules
  • Indicate which parameters are not required for querying all objects
  • Added missing RETURN information
  • Remove module aci_domain_to_encap_pool
  • Reformat copyright statement

This fixes #36230

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

aci modules and guide

ANSIBLE VERSION

v2.5

This PR includes:
- We moved the object class information to the notes
- Add version information to guide chapters
- Add generic note to modules with reference to ACI guide
- Reference known issues in aci_rest documentation
- Remove module_utils function docs from modules
- Indicate which parameters are not required for querying all objects
- Added missing RETURN information
@dagwieers dagwieers added the aci Cisco ACI community label Feb 21, 2018
@dagwieers dagwieers added this to the 2.5.0 milestone Feb 21, 2018
@dagwieers dagwieers added this to To Do in 2.5.x blocker list via automation Feb 21, 2018
@ansibot ansibot added docs_pull_request needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. ci_verified Changes made in this PR are causing tests to fail. labels Feb 21, 2018
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Feb 21, 2018
@dagwieers dagwieers merged commit 7435e11 into ansible:devel Feb 21, 2018
cyberark-bizdev pushed a commit to cyberark-bizdev/ansible that referenced this pull request Feb 22, 2018
* ACI: Various changes to module documentation and guide

This PR includes:
- We moved the object class information to the notes
- Add version information to guide chapters
- Add generic note to modules with reference to ACI guide
- Reference known issues in aci_rest documentation
- Remove module_utils function docs from modules
- Indicate which parameters are not required for querying all objects
- Added missing RETURN information

* Fix copyright strings

* Remove aci_domain_to_encap_pool.py for v2.5

* More updates

* PEP8 fix

* Improve listings of parameters/return values
@nitzmahone nitzmahone moved this from To Do to Done in 2.5.x blocker list Feb 22, 2018
@ansibot ansibot added docs This issue/PR relates to or includes documentation. and removed docs_pull_request labels Mar 4, 2018
@dagwieers dagwieers added cisco Cisco technologies networking Network category labels Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aci Cisco ACI community cisco Cisco technologies docs This issue/PR relates to or includes documentation. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. networking Network category
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

aci_domain_to_encap_pool: Issues with VXLAN and VSAN
2 participants