Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bp 2.5 ansible interpreter py3 #36561

Merged
merged 2 commits into from
Feb 22, 2018

Conversation

abadger
Copy link
Contributor

@abadger abadger commented Feb 22, 2018

SUMMARY

Backport of #36541 to stable-2.5

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

module_common.py

ANSIBLE VERSION
2.5.0
ADDITIONAL INFORMATION

Approved by 2.5 RM in the original PR.

* Fix types when evaluating interpreter. Fixes ansible#36536
* Rename variables that contain bytes to b_*
* Get rid of to_text() and to_bytes() calls that do nothing (because the
  data is already the proper type)

(cherry picked from commit a4df4d3)
@abadger abadger added this to To Do in 2.5.x blocker list via automation Feb 22, 2018
@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. bugfix_pull_request needs_triage Needs a first human triage before being processed. python3 support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Feb 22, 2018
@abadger abadger force-pushed the bp-2.5-ansible_interpreter-py3 branch from 74b065f to 3d3e28d Compare February 22, 2018 02:48
@abadger abadger merged commit e93cc41 into ansible:stable-2.5 Feb 22, 2018
@abadger abadger deleted the bp-2.5-ansible_interpreter-py3 branch February 22, 2018 04:05
@nitzmahone nitzmahone moved this from To Do to Done in 2.5.x blocker list Feb 22, 2018
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Feb 23, 2018
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. python3 support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants