yum: fix yum version comparison #36573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
bugfix_pull_request
core_review
Akasurde
removed
the
needs_triage
Akasurde
reviewed
Feb 22, 2018
| @@ -347,7 +348,7 @@ def is_group_env_installed(name, conf_file, installroot='/'): | |||
| name_lower = name.lower() | |||
|
|
|||
| my = yum_base(conf_file, installroot) | |||
| if yum.__version__ >= '3.4': | |||
| if LooseVersion(yum.__version__) >= LooseVersion('3.4'): | |||
There was a problem hiding this comment.
LooseVersion is broken in Python 3
There was a problem hiding this comment.
@abadger any hints on what is proper way of doing this?
There was a problem hiding this comment.
For yum, use yum.__version_info__ to compare against.
mkrizek
changed the title
ansibot
added
shipit
ansibot
added
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ISSUE TYPE
COMPONENT NAME
yum
ANSIBLE VERSION
ADDITIONAL INFORMATION