Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_group:documentation explicit a behaviour for sg rules #36586

Merged
merged 1 commit into from Feb 22, 2018
Merged

ec2_group:documentation explicit a behaviour for sg rules #36586

merged 1 commit into from Feb 22, 2018

Conversation

julienvey
Copy link
Contributor

SUMMARY

Fixes ##35811

Explicit a behaviour described in AWS documentation.
When setting IpProtocol (or proto in ansible) to all, traffic on all ports is allowed, regardless of any ports you specify

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

ec2_group

ANSIBLE VERSION
2.6.0

@ansibot
Copy link
Contributor

ansibot commented Feb 22, 2018

cc @adq @willthames
click here for bot help

@ansibot ansibot added aws cloud core_review In order to be merged, this PR must follow the core review workflow. docs_pull_request module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Feb 22, 2018
@willthames willthames merged commit d212bcf into ansible:devel Feb 22, 2018
@willthames
Copy link
Contributor

@julienvey if you raise this PR against stable-2.5 we can get it into the 2.5 docs too.

@julienvey julienvey deleted the issue35811 branch February 23, 2018 09:38
@julienvey julienvey mentioned this pull request Feb 23, 2018
Merged
@julienvey
Copy link
Contributor Author

@willthames here it is #36627

@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Mar 2, 2018
@ansibot ansibot added docs This issue/PR relates to or includes documentation. and removed docs_pull_request labels Mar 4, 2018
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@willthames willthames willthames approved these changes

Assignees
No one assigned
Labels
aws cloud core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@julienvey @ansibot @willthames @s-hertel