Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change docs for mime-type #36693

Merged
merged 2 commits into from
Aug 29, 2018
Merged

change docs for mime-type #36693

merged 2 commits into from
Aug 29, 2018

Conversation

rusik69
Copy link
Contributor

@rusik69 rusik69 commented Feb 25, 2018

SUMMARY

changes docs for stat module to fix that mime-type shows non human-readable file description

Fixes #36691

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

stat.py

ANSIBLE VERSION
ADDITIONAL INFORMATION
ansible 2.4.1.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/rgustomi/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/rgustomi/.local/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.14 (default, Feb 17 2018, 10:42:17) [GCC 7.3.1 20180130 (Red Hat 7.3.1-2)]

@ansibot
Copy link
Contributor

ansibot commented Feb 25, 2018

cc @bpennypacker
click here for bot help

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. docs_pull_request module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Feb 25, 2018
@alikins alikins removed the needs_triage Needs a first human triage before being processed. label Feb 26, 2018
@ansibot ansibot added docs This issue/PR relates to or includes documentation. and removed docs_pull_request labels Mar 1, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 9, 2018
@ansibot ansibot added the affects_2.6 This issue/PR affects Ansible v2.6 label May 20, 2018
@acozine
Copy link
Contributor

acozine commented Aug 24, 2018 •
edited

@Loqutus thanks for reading the documentation so carefully, and for submitting this fix. If I'm reading the related issue (#36691) correctly, should this PR also update line 318 to change mime_type to mimetype?

@acozine acozine self-assigned this Aug 24, 2018
@acozine acozine added the waiting_on_contributor This would be accepted but there are no plans to actively work on it. label Aug 27, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 29, 2018
@acozine acozine removed the waiting_on_contributor This would be accepted but there are no plans to actively work on it. label Aug 29, 2018
@acozine acozine merged commit 305ae54 into ansible:devel Aug 29, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@acozine acozine

Labels
affects_2.6 This issue/PR affects Ansible v2.6 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stat documentation: mime_type vs mimetype, mime output vs descriptive output
4 participants
@rusik69 @ansibot @acozine @alikins