Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip fmg_script unit test if the pyFMG script is not present #36732

Merged
merged 2 commits into from
Feb 26, 2018
Merged

skip fmg_script unit test if the pyFMG script is not present #36732

merged 2 commits into from
Feb 26, 2018

Conversation

newswangerd
Copy link
Member

SUMMARY

Fixes #35725

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

fmgr_script

ANSIBLE VERSION
ansible 2.6.0 (devel fb1ff6d852) last updated 2018/02/26 08:10:13 (GMT -400)
  config file = None
  configured module search path = [u'/Users/david/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/david/code/ansible/lib/ansible
  executable location = /Users/david/code/ansible/bin/ansible
  python version = 2.7.10 (default, Jul 15 2017, 17:16:57) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.31)]
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Feb 26, 2018

cc @Qalthos @ganeshrn @gundalow @kedarX @privateip @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added bugfix_pull_request needs_triage Needs a first human triage before being processed. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Feb 26, 2018
@newswangerd newswangerd mentioned this pull request Feb 26, 2018
Closed
@gundalow gundalow removed the needs_triage Needs a first human triage before being processed. label Feb 26, 2018
@gundalow
Copy link
Contributor

Thanks. Once green please cherry pick into 2.5

@ansibot
Copy link
Contributor

ansibot commented Feb 26, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

test/units/modules/network/fortimanager/test_fmgr_script.py:36:1: E302 expected 2 blank lines, found 1

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 26, 2018
@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 26, 2018
@newswangerd newswangerd merged commit 6bd715a into ansible:devel Feb 26, 2018
newswangerd added a commit to newswangerd/ansible that referenced this pull request Feb 26, 2018
@newswangerd
skip fmg_script unit test if the pyFMG script is not present (ansible…
ed6014a 
…#36732)

* skip fmg_script unit test if the pyFMG script is not present

* appease the sanity test gods

(cherry picked from commit 6bd715a)
newswangerd added a commit that referenced this pull request Feb 26, 2018
@newswangerd
skip fmg_script unit test if the pyFMG script is not present (#36732) (…
e1eae55 
…#36749)

* skip fmg_script unit test if the pyFMG script is not present

* appease the sanity test gods

(cherry picked from commit 6bd715a)
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@dagwieers dagwieers added the fortimanager Fortimanager community label Feb 22, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug. fortimanager Fortimanager community networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fortinet unit tests is breaking when pyFMG is not installed
4 participants
@newswangerd @ansibot @gundalow @dagwieers