Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

actual error reporting on failed galaxy clone #36788

Merged
merged 3 commits into from
Apr 10, 2018
Merged

actual error reporting on failed galaxy clone #36788

merged 3 commits into from
Apr 10, 2018

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Feb 27, 2018

SUMMARY

also allow debugging to see stdout/stderr from command

we were not being 'nice' by devnulling all this info.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

role requirement

ANSIBLE VERSION
2.4/2.5/2.6

@bcoca bcoca added this to To Do in 2.5.x blocker list via automation Feb 27, 2018
@ansibot ansibot added bugfix_pull_request needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 27, 2018
@gundalow gundalow removed the needs_triage Needs a first human triage before being processed. label Feb 28, 2018
@mattclay
Copy link
Member

CI failure in integration tests:

2018-02-27 16:35:57  [WARNING]: - test-role was NOT installed successfully: when executing git
2018-02-27 16:35:57 clone file:////var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/tmp.KHggyzfu
2018-02-27 16:35:57 /test-role test-role: 'str' object has no attribute 'fileno'

@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Feb 28, 2018
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 2, 2018
@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 7, 2018
@gundalow gundalow changed the title actual error reprting on failed galaxy clone actual error reporting on failed galaxy clone Mar 8, 2018
@nitzmahone nitzmahone moved this from To Do to 2.5.1 Holding in 2.5.x blocker list Mar 9, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 16, 2018
@bcoca
actual error reprting on failed galaxy clone
a2a4ca8 
also allow debugging to see stdout/stderr from command
@bcoca
handle output for all commands on error
020e07f 
also use std temp dir instead of random
@bcoca
fixed typoe
2ee340a
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 10, 2018
@bcoca bcoca merged commit fda9312 into ansible:devel Apr 10, 2018
@bcoca bcoca deleted the galaxy_clone_errinfo branch April 10, 2018 21:26
@nitzmahone nitzmahone moved this from 2.5.1 Holding to 2.5.2 holding in 2.5.x blocker list Apr 18, 2018
@bcoca bcoca removed this from 2.5.2 holding in 2.5.x blocker list Apr 27, 2018
@bcoca bcoca mentioned this pull request Aug 10, 2018
Closed
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@bcoca @ilicmilan
actual error reporting on failed galaxy clone (ansible#36788)
e13c88c 
actual error reprting on failed galaxy clone

also allow debugging to see stdout/stderr from command
handle output for all commands on error
also use std temp dir instead of random
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bcoca @mattclay @gundalow @ansibot