Fix redundant yaml error blurbs on ModArgs parse errors #36923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the AnsibleParserErrors from parsing.mod_args are created with the obj=some_yaml_ds options but some are not. If they were, we don't want to add another yaml_ds to it, because that will result in double yaml error blurbs. And since we dont need to add info, we can just re raise it. But if there is no ._obj, add it here so we get the extra detail in the error message (see issue #14790) and raise a new AnsibleParserError instance. Fixes #36848
ansibot
added
bug
|
The test |
ansibot
added
the
needs_revision
ansibot
removed
the
needs_revision
mkrizek
removed
the
needs_triage
ansibot
added
the
stale_ci
abadger
reviewed
Mar 19, 2018
| # so we dont need to add it so we can just re raise. | ||
| if e._obj: | ||
| raise | ||
| # But if it wasn't, we can add the yaml object now to get more detail | ||
| raise AnsibleParserError(to_native(e), obj=ds, orig_exc=e) |
There was a problem hiding this comment.
Is there a difference between obj and _obj ?
|
I like what you're doing here. If my question has an answer that you've already considered, then +1 to merge from me. |
|
cherry-picked to stable-2.5 for 2.5.1 |
nitzmahone
pushed a commit
that referenced
this pull request
Mar 29, 2018
* Fix redundant yaml error blurbs on ModArgs parse errors Some of the AnsibleParserErrors from parsing.mod_args are created with the obj=some_yaml_ds options but some are not. If they were, we don't want to add another yaml_ds to it, because that will result in double yaml error blurbs. And since we dont need to add info, we can just re raise it. But if there is no ._obj, add it here so we get the extra detail in the error message (see issue #14790) and raise a new AnsibleParserError instance. Fixes #36848 * cleanup existing test_tasks pep8/sanity issues (cherry picked from commit e166946)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the AnsibleParserErrors from parsing.mod_args
are created with the obj=some_yaml_ds options but
some are not.
If they were, we don't want to add another yaml_ds to
it, because that will result in double yaml error blurbs.
And since we dont need to add info, we can just re raise it.
But if there is no ._obj, add it here so we get the extra
detail in the error message (see issue #14790) and raise
a new AnsibleParserError instance.
Fixes #36848
SUMMARY
ISSUE TYPE
COMPONENT NAME
lib/ansible/playbook/task.py
ANSIBLE VERSION