Add name_tag option to set name tag on created disk. #3693
Conversation
|
It feels like we should be able to generically just specify a list of tags like the ec2 module. it is currently true that in the ec2 module the name tag must be JSON, but I want to see it updated so that if not JSON and actually a complex argument in Ansible we can work with that too, but also simple key=value pairs. This code should be cleaned up and standardized first, then we need to make this module do the same. I would hope that it could set multiple tags like the other rather than just setting one tag. This will also be needing a rebase but per the above we are not ready to merge now. cc @lwade |
docfix: grammar in docstring for sysctl module
This reverts commit 1a4e6e4.
Previous patch was reverted due to the fact that there was an issue with the results not always being a dictionary (they're sometimes a unicode string, ie. when the with_items is used with yum). This minor change corrects that by checking for a dict object.
Conflicts: library/cloud/ec2_vol
|
o.O looks like this has gone a little squiffy. Regarding tags, we need an ec2_tag module which we can use to set tags on any resource, then we should back out tag functionality from modules, imo. Since most things can be tagged in AWS I think this makes most sense. |
|
I know we need an ec2_tag module. But now we have nothing, so I reckoned something was better than nothing. |
|
Merged in the ec2_tag module today, so I'm going to go ahead and close this. |
ansibot
added
feature
Add option to give a name to created ec2 volumes, with a lot of volumes they easily get lost otherwise.
Probably this approach needs to be revisited when generic tagging is going to be supported, but this is at least a step forward.
PS: new pull request to make sure it is a clean request.