Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module pamd hardcodes path to temp directory #36954

Closed
ericwb opened this issue Mar 2, 2018 · 2 comments · Fixed by #47133
Closed

module pamd hardcodes path to temp directory #36954

ericwb opened this issue Mar 2, 2018 · 2 comments · Fixed by #47133
Labels
affects_2.3 This issue/PR affects Ansible v2.3 bug This issue/PR relates to a bug. support:core This issue/PR relates to code supported by the Ansible Engineering Team.

Comments

@ericwb
Copy link
Contributor

ericwb commented Mar 2, 2018

ISSUE TYPE
  • Bug Report
COMPONENT NAME
ANSIBLE VERSION
ansible 2.3.1.0
  config file = 
  configured module search path = Default w/o overrides
  python version = 2.7.13 (default, Feb  1 2017, 13:04:42) [GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.42.1)]
CONFIGURATION
OS / ENVIRONMENT

Mac OS X 10.12.6

SUMMARY

The pamd module is hardcoding references to a '/tmp' directory instead of using Python's tempfile.
It assumes that /tmp is the always the TMP directory, which is not the case.

https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/system/pamd.py#L387

STEPS TO REPRODUCE



EXPECTED RESULTS



ACTUAL RESULTS







      		
    

      
  





        

            

            

              
            

        

      


      
    








      

    



      

  
      



  

  @bcoca





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

      

  
  Member


      

  


  

    

      

      
          bcoca
  

      

      

      commented


        Mar 2, 2018


      
    


  





      


        


  
    

      
          
it should be using the configured remote_tmp (accessible via module.tempdir property)

      		
    

  





        


            

              
            

        

      


      

            
  

    
  
  

  

  



    












      

  
          

  

    
  

  


    

        @ansibot
ansibot




          added
      

  affects_2.3

  This issue/PR affects Ansible v2.3

      

  bug

  This issue/PR relates to a bug.

      

  needs_triage

  Needs a first human triage before being processed.

      

  support:core

  This issue/PR relates to code supported by the Ansible Engineering Team.

  labels


    Mar 2, 2018

  





  

  

    
  

  


    

        @s-hertel
s-hertel




        removed
  the 

  needs_triage

  Needs a first human triage before being processed.
 label


    Mar 2, 2018

  





  

  

    
  


  

      

    @ericwb
ericwb



    mentioned this issue
    
      Apr 3, 2018
    





  


  

      
   Closed

  







  









      

  
      



  

  @juliedavila





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
fixed by #47133

      		
    

  





        


            

              
            

        

      


      

            
  

    
  
  

  

  



    












      

  
          

  

    
  


  

      

    @juliedavila
juliedavila



    mentioned this issue
    
      Oct 16, 2018
    





  


  

      
   Merged

  







  




  

  


  

  

    
  

  


    

        @ansible
ansible




      locked and limited conversation to collaborators


    Jul 22, 2019

  














  
  

    

      

  





  




  
  

             

  
      Sign up for free
      to subscribe to this conversation on GitHub.
      Already have an account?
      Sign in.


  


  






  
                  




    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

      

    affects_2.3

  This issue/PR affects Ansible v2.3
  

    bug

  This issue/PR relates to a bug.
  

    support:core

  This issue/PR relates to code supported by the Ansible Engineering Team.








      

  

    

        

    Projects
  


        




    None yet




  



      

  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  




            
Successfully merging a pull request may close this issue.





    


  
          
      pamd: use module.tmpdir for NamedTemporaryFile()






    
  




        
      

    

  
      

  

    

      5 participants
    

    

        
          @bcoca 
        
          @juliedavila 
        
          @ericwb 
        
          @ansibot 
        
          @s-hertel