Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't fail on configure in command (#37011) #37094

Merged
merged 1 commit into from
Mar 6, 2018
Merged

Don't fail on configure in command (#37011) #37094

merged 1 commit into from
Mar 6, 2018

Conversation

Qalthos
Copy link
Contributor

@Qalthos Qalthos commented Mar 6, 2018

  • Don't fail on configure in command

  • Change test to check mode

(cherry picked from commit efb8b53)

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ios_command

ANSIBLE VERSION
2.5

@Qalthos
Don't fail on configure in command (ansible#37011)
d8e05d5 
* Don't fail on configure in command

* Change test to check mode

(cherry picked from commit efb8b53)
@ansibot
Copy link
Contributor

ansibot commented Mar 6, 2018

cc @ganeshrn @gdpak @gundalow @kedarX @privateip @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels Mar 6, 2018
@Qalthos Qalthos removed the needs_triage Needs a first human triage before being processed. label Mar 6, 2018
@Qalthos Qalthos merged commit 2be960f into ansible:stable-2.5 Mar 6, 2018
@Qalthos Qalthos deleted the pick-2.5 branch March 6, 2018 23:24
@dagwieers dagwieers added ios Cisco IOS community cisco Cisco technologies labels Feb 27, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. ios Cisco IOS community module This issue/PR relates to a module. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Qalthos @ansibot @dagwieers