VMware: new module : vmware_cluster_facts #37105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
cloud
module
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Akasurde
force-pushed
the
vmware_cluster_facts
branch
from
9611d86
to
abc2eda
Compare
Akasurde
removed
the
needs_triage
|
@Akasurde @bedecarroll @chrrrles @dav1x @garbled1 @jjahns @kamsz @lrivallain @nafpliot-ibm @nerzhul @pdellaert @rhoop @ritzk @stravassac @tchernomax @woshihaoren As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add |
ansibot
added
community_review
|
@pdellaert @tchernomax Could you please review this ? |
ansibot
added
the
stale_ci
pdellaert
approved these changes
Mar 22, 2018
|
|
||
| self.cluster_objs = [cluster_obj] | ||
|
|
||
| def get_all_cluster_objs(self, parent): |
There was a problem hiding this comment.
Could potentially be moved to the module_utils? (same for lines 112 -> 122)
ansibot
added
shipit
|
rebuild_merge |
|
@pdellaert Thanks for review. |
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 14, 2018
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 15, 2018
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
ilicmilan
pushed a commit
to ilicmilan/ansible
that referenced
this pull request
Nov 7, 2018
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com
ISSUE TYPE
COMPONENT NAME
lib/ansible/modules/cloud/vmware/vmware_cluster_facts.py
test/integration/targets/vmware_cluster_facts/aliases
test/integration/targets/vmware_cluster_facts/tasks/main.yml
ANSIBLE VERSION