Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cs_ip_address.py: fix missing doc #37109

Merged
merged 2 commits into from Mar 7, 2018
Merged

cs_ip_address.py: fix missing doc #37109

merged 2 commits into from Mar 7, 2018

Conversation

resmo
Copy link
Contributor

@resmo resmo commented Mar 7, 2018

SUMMARY

fix missing doc for an existing arg spec.

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME

cs_ip_address

ANSIBLE VERSION
2.5
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Mar 7, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 5 errors:

lib/ansible/modules/cloud/cloudstack/cs_ip_address.py:0:0: E309 version_added for new option (state) should be 2.6. Currently 0.0
test/sanity/validate-modules/ignore.txt:371:1: A102 Remove since "lib/ansible/modules/cloud/cloudstack/cs_ip_address.py" passes "E322" test
test/sanity/validate-modules/ignore.txt:372:1: A102 Remove since "lib/ansible/modules/cloud/cloudstack/cs_ip_address.py" passes "E324" test
test/sanity/validate-modules/ignore.txt:373:1: A102 Remove since "lib/ansible/modules/cloud/cloudstack/cs_ip_address.py" passes "E325" test
test/sanity/validate-modules/ignore.txt:374:1: A102 Remove since "lib/ansible/modules/cloud/cloudstack/cs_ip_address.py" passes "E326" test

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Mar 7, 2018

cc @DazWorrall @dpassante
click here for bot help

@ansibot ansibot added bug This issue/PR relates to a bug. ci_verified Changes made in this PR are causing tests to fail. cloud cloudstack module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Mar 7, 2018
gundalow
gundalow requested changes Mar 7, 2018
View reviewed changes
Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@resmo Looks good, if you could please remove the 4 lines form ignore.txt in this PR we can get this merged.

You can ignore the version_added message about state, that error will go away after merge

@gundalow gundalow added this to To Do in 2.5.x blocker list via automation Mar 7, 2018
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Mar 7, 2018
@ansibot
Copy link
Contributor

ansibot commented Mar 7, 2018

cc @mattclay
click here for bot help

@ansibot ansibot added support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. and removed ci_verified Changes made in this PR are causing tests to fail. labels Mar 7, 2018
@ansibot
Copy link
Contributor

ansibot commented Mar 7, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/cloudstack/cs_ip_address.py:0:0: E309 version_added for new option (state) should be 2.6. Currently 0.0

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Mar 7, 2018
@gundalow gundalow merged commit 67d8c8f into ansible:devel Mar 7, 2018
@gundalow
Copy link
Contributor

gundalow commented Mar 7, 2018

Merged into devel If you'd like to create a cherry-pick PR with this and the dependencies in I can merge that into stable-2.5. thanks

@resmo resmo deleted the fix/cs_ip_address_doc branch March 7, 2018 13:24
@resmo
Copy link
Contributor Author

resmo commented Mar 7, 2018

@gundalow creating a backport PR

resmo added a commit that referenced this pull request Mar 7, 2018
@resmo
cs_ip_address.py: fix missing doc (#37109)
c054527 
* cs_ip_address.py: fix missing doc

* update ignore.txt

(partly cherry picked from commit 67d8c8f)
@gundalow gundalow moved this from To Do to Done in 2.5.x blocker list Mar 8, 2018
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug. ci_verified Changes made in this PR are causing tests to fail. cloud cloudstack module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
No open projects
2.5.x blocker list
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@resmo @ansibot @gundalow