Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bkprt unarchive fix #37159

Merged
merged 2 commits into from
Mar 8, 2018
Merged

Bkprt unarchive fix #37159

merged 2 commits into from
Mar 8, 2018

Conversation

abadger
Copy link
Contributor

@abadger abadger commented Mar 8, 2018

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/files/unarchive.py

ANSIBLE VERSION
2.5

@abadger
Fix unarchive with strip-components in extra_opts (ansible#37048)
fa561ae 
* Fix unarchive with strip-components in extra_opts

When unarchive is given extra_opts to strip all leading directories, it
could end up trying to change the permissions on the root directory.
Tar archives shouldn't contain absolute paths anyways so make sure that
all paths are relative as we handle them.

Fixes ansible#21397

(cherry picked from commit cca0cca)
@abadger
Add changelog fragment for the unarchive permissions fix
b9f7421
@ansibot
Copy link
Contributor

ansibot commented Mar 8, 2018

cc @pileofrogs
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. m:unarchive This issue/PR relates to the unarchive module. labels Mar 8, 2018
@abadger abadger merged commit 0fd9c9b into ansible:stable-2.5 Mar 8, 2018
@abadger abadger deleted the bkprt-unarchive-fix branch March 8, 2018 02:41
@abadger
Copy link
Contributor Author

abadger commented Mar 8, 2018

Merged for 2.5.0rc2

@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Mar 9, 2018
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. m:unarchive This issue/PR relates to the unarchive module. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@abadger @ansibot @s-hertel