Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMware: new module: vmware_vswitch_facts #37176

Merged
merged 1 commit into from May 7, 2018

Conversation

Akasurde
Copy link
Member

@Akasurde Akasurde commented Mar 8, 2018

SUMMARY

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/vmware/vmware_vswitch_facts.py
test/integration/targets/vmware_vswitch_facts/aliases
test/integration/targets/vmware_vswitch_facts/tasks/main.yml

ANSIBLE VERSION
2.6devel

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansibot
Copy link
Contributor

ansibot commented Mar 8, 2018

@ansibot ansibot added cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. vmware VMware community labels Mar 8, 2018
@ansibot
Copy link
Contributor

ansibot commented Mar 8, 2018

@Akasurde @bedecarroll @chrrrles @dav1x @garbled1 @jjahns @kamsz @lrivallain @nafpliot-ibm @nerzhul @pdellaert @rhoop @ritzk @stravassac @tchernomax @woshihaoren

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Mar 8, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 16, 2018
@ansibot
Copy link
Contributor

ansibot commented May 3, 2018

Copy link
Contributor

@pdellaert pdellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels May 6, 2018
@Akasurde
Copy link
Member Author

Akasurde commented May 7, 2018

rebuild_merge

@ansibot ansibot merged commit 02f1d26 into ansible:devel May 7, 2018
@Akasurde Akasurde deleted the vmware_vswitch_facts branch May 7, 2018 06:57
@Akasurde
Copy link
Member Author

Akasurde commented May 7, 2018

@pdellaert Thanks for the review.

oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 12, 2018
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
tonal pushed a commit to tonal/ansible that referenced this pull request May 15, 2018
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansible ansible locked and limited conversation to collaborators May 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cloud module This issue/PR relates to a module. new_module This PR includes a new module. new_plugin This PR includes a new plugin. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. vmware VMware community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants