uri: Add form-urlencoded support to body_format #37188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagwieers
force-pushed
the
uri-formencoded
branch
from
fc11015
to
bbccbe3
Compare
ansibot
added
core_review
dagwieers
force-pushed
the
uri-formencoded
branch
from
bbccbe3
to
b490681
Compare
ansibot
added
stale_ci
|
@romeotheriault Can we merge this ? |
sivel
reviewed
Mar 22, 2018
dagwieers
force-pushed
the
uri-formencoded
branch
4 times, most recently
from
c5d71bf
to
f1c71ed
Compare
ansibot
added
needs_revision
dagwieers
force-pushed
the
uri-formencoded
branch
from
f1c71ed
to
c0ccfb7
Compare
This comment has been minimized.
This comment has been minimized.
mattclay
added
the
ci_verified
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ansibot
removed
the
ci_verified
ansibot
added
the
needs_revision
This PR adds form-urlencoded support so the user does not need to take care of correctly encode input and have the same convenience as using JSON. This fixes ansible#37182
dagwieers
force-pushed
the
uri-formencoded
branch
from
cb1270e
to
9f45edd
Compare
ansibot
removed
the
stale_ci
ansibot
added
the
stale_ci
ansibot
added
stale_review
ansibot
added
the
stale_ci
No longer my problem
dagwieers
force-pushed
the
uri-formencoded
branch
from
9d982df
to
230074b
Compare
ansibot
removed
stale_ci
|
Ready for re-review. |
dagwieers
force-pushed
the
uri-formencoded
branch
from
f475c54
to
934cfff
Compare
|
@sivel Can we get this merged before v2.6 is branched ? |
sivel
approved these changes
May 17, 2018
|
rebuild_merge |
ansibot
added
core_review
achinthagunasekara
pushed a commit
to achinthagunasekara/ansible
that referenced
this pull request
May 23, 2018
* uri: Add form-urlencoded support to body_format This PR adds form-urlencoded support so the user does not need to take care of correctly encode input and have the same convenience as using JSON. This fixes ansible#37182 * Various fixes * Undo documentation improvements No longer my problem * Fix the remaining review comments
jacum
pushed a commit
to jacum/ansible
that referenced
this pull request
Jun 26, 2018
* uri: Add form-urlencoded support to body_format This PR adds form-urlencoded support so the user does not need to take care of correctly encode input and have the same convenience as using JSON. This fixes ansible#37182 * Various fixes * Undo documentation improvements No longer my problem * Fix the remaining review comments
ilicmilan
pushed a commit
to ilicmilan/ansible
that referenced
this pull request
Nov 7, 2018
* uri: Add form-urlencoded support to body_format This PR adds form-urlencoded support so the user does not need to take care of correctly encode input and have the same convenience as using JSON. This fixes ansible#37182 * Various fixes * Undo documentation improvements No longer my problem * Fix the remaining review comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR adds form-urlencoded support so the user does not need to take
care of correctly encoded input and have the same convenience as using
JSON.
Compatible with Requests.
This fixes #37182
ISSUE TYPE
COMPONENT NAME
uri
ANSIBLE VERSION
v2.5