Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added junos_smoke tests #37216

Merged
merged 3 commits into from
Apr 4, 2018
Merged

added junos_smoke tests #37216

merged 3 commits into from
Apr 4, 2018

Conversation

newswangerd
Copy link
Member

@newswangerd newswangerd commented Mar 8, 2018 •
edited

SUMMARY

Adds junos_smoke tests
Covers:

module_utils:

  • network.common.utils
  • network.common.config
  • network.junos

plugins:

  • plugins.action.junos
  • plugins. cliconf.junos
  • plugins.terminal.junos
  • plugins.netconf.junos

Coverage results:
https://newswangerd.github.io/junos/
*Note, coverage results are for an older commit in stable-2.5 because of #37530

cliconf.junos.py is mostly untested because the only modules which support cliconf are junos_command and junos_netconf.

ISSUE TYPE
  • Test pull request
COMPONENT NAME
ANSIBLE VERSION
ansible 2.6.0 (junos_smoke 263b5b99de) last updated 2018/03/08 15:26:48 (GMT -400)
  config file = None
  configured module search path = [u'/Users/david/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/david/code/ansible/lib/ansible
  executable location = /Users/david/code/ansible/bin/ansible
  python version = 2.7.10 (default, Jul 15 2017, 17:16:57) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.31)]
ADDITIONAL INFORMATION

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Mar 8, 2018
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Mar 9, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 17, 2018
@newswangerd newswangerd changed the title [WIP] added junos_smoke tests added junos_smoke tests Mar 23, 2018
@ansibot ansibot removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Mar 23, 2018
@newswangerd
Copy link
Member Author

Tests pass on DCI

@newswangerd newswangerd merged commit 0bd2cd4 into ansible:devel Apr 4, 2018
ryancurrah pushed a commit to ryancurrah/ansible that referenced this pull request Apr 4, 2018
@newswangerd @ryancurrah
added junos_smoke tests (ansible#37216)
1ad7999 
* added junos_smoke tests

* enable check mode test

* fix check mode test
newswangerd added a commit to newswangerd/ansible that referenced this pull request Apr 6, 2018
@newswangerd
added junos_smoke tests (ansible#37216)
07acf05 
* added junos_smoke tests

* enable check mode test

* fix check mode test

(cherry picked from commit 0bd2cd4)
@newswangerd
Copy link
Member Author

backport: #38396

newswangerd added a commit that referenced this pull request Apr 6, 2018
@newswangerd
added junos_smoke tests (#37216) (#38396)
f25eea1 
* added junos_smoke tests

* enable check mode test

* fix check mode test

(cherry picked from commit 0bd2cd4)
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@newswangerd @ilicmilan
added junos_smoke tests (ansible#37216)
fa9ff53 
* added junos_smoke tests

* enable check mode test

* fix check mode test
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ganeshrn ganeshrn ganeshrn approved these changes

@gundalow gundalow Awaiting requested review from gundalow

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@newswangerd @ganeshrn @ansibot @s-hertel