now uses get_bin_path for lvg executables

[bcoca]

should fix #3713 w/o needing setting path in enviornment: as a work around
Signed-off-by: Brian Coca briancoca+dev@gmail.com

[mpdehaan]

Stylistic request:

+                        rc,_,err = module.run_command("%s %s"%(pvcreate_cmd,current_dev))

Can this be changed to:

+                        rc,_,err = module.run_command("%s %s" % (pvcreate_cmd, current_dev))

Thanks!

[bcoca]

i tried to change as little as possible, followed the original style, but
yes, much more readable.

i'll update branch

On Wed, Jul 31, 2013 at 11:09 PM, Michael DeHaan
notifications@github.comwrote:

Stylistic request:

• rc,_,err = module.run_command("%s %s"%(pvcreate_cmd,current_dev))

Can this be changed to:

• rc,_,err = module.run_command("%s %s" % (pvcreate_cmd, current_dev))

Thanks!

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/3722#issuecomment-21911755
.

Brian Coca
Stultorum infinitus est numerus
0110000101110010011001010110111000100111011101000010000001111001011011110111010100100000011100110110110101100001011100100111010000100001
Pedo mellon a minno

[sfromm]

one small bug. at line 213, module.run_command() has a flawed call to vgextend:

rc,_,err = module.run_command("vgextend %s %s"%(vgextend_cmd, vg, devs_to_add_string))

Looks like it should be:

rc,_,err = module.run_command("%s %s %s" % (vgextend_cmd, vg, devs_to_add_string))

[bcoca]

thnx, fixing

On Thu, Aug 1, 2013 at 12:21 AM, Stephen Fromm notifications@github.comwrote:

one small bug. at line 213, module.run_command() has a flawed call to
vgextend:

rc,_,err = module.run_command("vgextend %s %s"%(vgextend_cmd, vg, devs_to_add_string))

Looks like it should be:

rc,_,err = module.run_command("%s %s %s" % (vgextend_cmd, vg, devs_to_add_string))

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/3722#issuecomment-21913727
.

Brian Coca
Stultorum infinitus est numerus
0110000101110010011001010110111000100111011101000010000001111001011011110111010100100000011100110110110101100001011100100111010000100001
Pedo mellon a minno

[mpdehaan]

merged, thank you!