Traceback in git module when version checkout fails

[psvo]

"UnboundLocalError: local variable 'branch' referenced before assignment" is
raised in git, line 282, in switch_version.

Exception is raised when version is not branch and version checkout fails.
E.g. when version is nonexistant commit.

Full traceback:

REMOTE_MODULE git repo="ssh://xxx/xxx.git" dest="/xxx" version="a98ef5944f5fe3969accfffa40e76fb43d6b49dc"

failed to parse: Traceback (most recent call last):
  File "/root/.ansible/tmp/ansible-1375350491.22-159151807716270/git", line 1306, in <module>
    main()
  File "/root/.ansible/tmp/ansible-1375350491.22-159151807716270/git", line 364, in main
    (rc, out, err) = switch_version(git_path, module, dest, remote, version)
  File "/root/.ansible/tmp/ansible-1375350491.22-159151807716270/git", line 282, in switch_version
    module.fail_json(msg="Failed to checkout branch %s" % (branch))
UnboundLocalError: local variable 'branch' referenced before assignment

[jimi-c]

Would it be better just to do this on line 283 (282 of the original):

module.fail_json(msg="Failed to checkout %s" % (version))

Since the checkout could be a tag as well as a branch or sha.

[psvo]

But than we will loose information about checked out branch when version is HEAD. Than maybe there should be something like:

module.fail_json(msg="Failed to checkout %s" % (version if version != HEAD else branch))

[psvo]

Hmm, but its python 2.5+ only, so maybe keeping current patch and removing branch from message would be good enough?

[mpdehaan]

Don't do the one line thing, instead do:

if version:
    module.fail_json(msg="Failed to checkout %s" % (version))
else branch:
    module.fail_json(...)

Also more readable.

Can you update this? Then I'll merge it in. Thanks!

[mpdehaan]

This should just say "if version", actually, but I'll take care of fixing it.

[mpdehaan]

ah, I see, the parameter is being reused for both tags and branches.

Got it, thanks!

[mpdehaan]

merged, thank you!