Various module doc fixes #37256
Merged
Various module doc fixes #37256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
bug
This PR includes: - A fix for multiple-choice defaults - A fix for messed up dictionary samples - Cleaner defaults when they don't appear part of choices
gundalow
approved these changes
Mar 9, 2018
dharmabumstead
approved these changes
Mar 12, 2018
privateip
added a commit
that referenced
this pull request
Mar 13, 2018
This reverts commit 80ba7b7.
nitzmahone
pushed a commit
that referenced
this pull request
Mar 16, 2018
This PR includes: - A fix for multiple-choice defaults - A fix for messed up dictionary samples - Cleaner defaults when they don't appear part of choices (cherry picked from commit 80ba7b7)
|
cherry picked to stable-2.5 for 2.5.0rc3 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR includes:
Missing choice before this PR
Missing choice after this PR
NOTE: This PR also fixes the module documentation to not use the default value as a free flow of text. We will have to add validation checks to avoid people abusing the default value.
Fixing the module docs, removing free text as default
Multiple choices before this PR
Multiple choice after this PR
ISSUE TYPE
COMPONENT NAME
module docs
ANSIBLE VERSION
v2.5