Allow using action/local_action on includes and imports

[sivel]

SUMMARY

Allow using action/local_action on includes and imports. Fixes #28822

Using action or local_action on includes and imports doesn't work. This is due to playbooks/helpers.py doing things like if 'include_role' in task_ds: which fails because the task_ds may look like:

{'local_action': {'module': 'include_role', 'name': 'foo'}}

or

{'local_action': 'include_role name=foo'}

This PR uses mod_args to determine the action in a more robust way.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

lib/ansible/playbooks/helpers.py

ANSIBLE VERSION

2.4
2.5
2.6

ADDITIONAL INFORMATION

[bcoca]

i think we should go in opposite direction and make sure that the 'action' gets set correctly and compare to that.

There are things that should never workd i.e action: module={{varwithimport_tasksvalue}}, but the rest should work with action/local_action even if the 'local' part is irrelevant.

[sivel]

i think we should go in opposite direction and make sure that the 'action' gets set correctly and compare to that.

I did specifically mention that I didn't think that was worthwhile. We could, but it would involve a much larger refactor.

Right now we have a lot of code that just does if "include" in task_ds:. Because at this point we haven't actually parsed the task ds. That happens later, after we determine if it is one of these special cases.

We have at least 3 variants we would have to support:

• if "include" in task_ds:
• if task_ds.get('module') == "include": <- this one would need wrapped in a try/except for when the value is not a dict
• Some parser to pull validate local_action: include foo.yml

I think we would end up either having to create a new parser, that is separate from Task, and effectively parse the task ds 2 times, or move parsing much farther forward.

[bcoca]

modargsparser does this already, we might just want to refactor it to allow for 'external use'

[sivel]

@bcoca I've updated the code to use ModuleArgsParser, my only concern is that without much more refactoring, we will end up calling ModuleArgsParser 2 times for the same task in some scenarios.