Add new Pure Storage module to discover facts for FlashArray #37263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
community_review
|
The test The test |
ansibot
added
ci_verified
sdodsley
force-pushed
the
purefa_facts
branch
2 times, most recently
from
a3c28a6
to
10568bf
Compare
ansibot
removed
the
ci_verified
|
The test |
ansibot
removed
the
ci_verified
|
The test The test |
sdodsley
force-pushed
the
purefa_facts
branch
3 times, most recently
from
7505ff2
to
b2431b5
Compare
ansibot
added
community_review
|
The test The test |
ansibot
removed
the
ci_verified
sdodsley
force-pushed
the
purefa_facts
branch
2 times, most recently
from
989f4f9
to
71bdb9b
Compare
|
The test |
ansibot
removed
the
ci_verified
|
The test The test The test |
ansibot
removed
the
ci_verified
|
The test The test |
|
The string contained within Below is a patch to fix diff --git a/lib/ansible/modules/storage/purestorage/purefa_facts.py b/lib/ansible/modules/storage/purestorage/purefa_facts.py
index 9229dc68c5..25baac1858 100644
--- a/lib/ansible/modules/storage/purestorage/purefa_facts.py
+++ b/lib/ansible/modules/storage/purestorage/purefa_facts.py
@@ -65,229 +65,229 @@ ansible_facts:
returned: always
type: complex
contains:
- "capacity": {},
- "config": {
- "directory_service": {
- "array_admin_group": null,
- "base_dn": null,
- "bind_password": null,
- "bind_user": null,
- "check_peer": false,
- "enabled": false,
- "group_base": null,
- "readonly_group": null,
- "storage_admin_group": null,
- "uri": []
- },
- "dns": {
- "domain": "domain.com",
- "nameservers": [
- "8.8.8.8",
- "8.8.4.4"
- ]
- },
- "ntp": [
- "0.ntp.pool.org",
- "1.ntp.pool.org",
- "2.ntp.pool.org",
- "3.ntp.pool.org"
- ],
- "smtp": [
- {
- "enabled": true,
- "name": "alerts@acme.com"
- },
- {
- "enabled": true,
- "name": "user@acme.com"
- }
- ],
- "snmp": [
- {
- "auth_passphrase": null,
- "auth_protocol": null,
- "community": null,
- "host": "localhost",
- "name": "localhost",
- "privacy_passphrase": null,
- "privacy_protocol": null,
- "user": null,
- "version": "v2c"
- }
- ],
- "ssl_certs": {
- "country": null,
- "email": null,
- "issued_by": "",
- "issued_to": "",
- "key_size": 2048,
- "locality": null,
- "organization": "Acme Storage, Inc.",
- "organizational_unit": "Acme Storage, Inc.",
- "state": null,
- "status": "self-signed",
- "valid_from": "2017-08-11T23:09:06Z",
- "valid_to": "2027-08-09T23:09:06Z"
- },
- "syslog": []
+ "capacity": {}
+ "config": {
+ "directory_service": {
+ "array_admin_group": null,
+ "base_dn": null,
+ "bind_password": null,
+ "bind_user": null,
+ "check_peer": false,
+ "enabled": false,
+ "group_base": null,
+ "readonly_group": null,
+ "storage_admin_group": null,
+ "uri": []
+ },
+ "dns": {
+ "domain": "domain.com",
+ "nameservers": [
+ "8.8.8.8",
+ "8.8.4.4"
+ ]
+ },
+ "ntp": [
+ "0.ntp.pool.org",
+ "1.ntp.pool.org",
+ "2.ntp.pool.org",
+ "3.ntp.pool.org"
+ ],
+ "smtp": [
+ {
+ "enabled": true,
+ "name": "alerts@acme.com"
},
- "default": {
- "array_name": "flasharray1",
- "hostgroups": 0,
- "hosts": 10,
- "protection_groups": 1,
- "purity_version": "5.0.4",
- "snapshots": 1
- },
- "hgroups": {},
- "hosts": {
- "host1": {
- "hgroup": null,
- "iqn": [
- "iqn.1994-05.com.redhat:2f6f5715a533"
- ],
- "wwn": []
- },
- "host2": {
- "hgroup": null,
- "iqn": [
- "iqn.1994-05.com.redhat:d17fb13fe0b"
- ],
- "wwn": []
- },
- "host3": {
- "hgroup": null,
- "iqn": [
- "iqn.1994-05.com.redhat:97b1351bfb2"
- ],
- "wwn": []
- },
- "host4": {
- "hgroup": null,
- "iqn": [
- "iqn.1994-05.com.redhat:dd84e9a7b2cb"
- ],
- "wwn": [
- "10000000C96C48D1",
- "10000000C96C48D2"
- ]
- }
- },
- "interfaces": {
- "CT0.ETH4": "iqn.2010-06.com.purestorage:flasharray.2111b767484e4682",
- "CT0.ETH5": "iqn.2010-06.com.purestorage:flasharray.2111b767484e4682",
- "CT1.ETH4": "iqn.2010-06.com.purestorage:flasharray.2111b767484e4682",
- "CT1.ETH5": "iqn.2010-06.com.purestorage:flasharray.2111b767484e4682"
- },
- "network": {
- "ct0.eth0": {
- "address": "10.10.10.10",
- "gateway": "10.10.10.1",
- "hwaddr": "ec:f4:bb:c8:8a:04",
- "mtu": 1500,
- "netmask": "255.255.255.0",
- "services": [
- "management"
- ],
- "speed": 1000000000
- },
- "ct0.eth2": {
- "address": "10.10.10.11",
- "gateway": null,
- "hwaddr": "ec:f4:bb:c8:8a:00",
- "mtu": 1500,
- "netmask": "255.255.255.0",
- "services": [
- "replication"
- ],
- "speed": 10000000000
- },
- "ct0.eth3": {
- "address": "10.10.10.12",
- "gateway": null,
- "hwaddr": "ec:f4:bb:c8:8a:02",
- "mtu": 1500,
- "netmask": "255.255.255.0",
- "services": [
- "replication"
- ],
- "speed": 10000000000
- },
- "ct0.eth4": {
- "address": "10.10.10.13",
- "gateway": null,
- "hwaddr": "90:e2:ba:83:79:0c",
- "mtu": 1500,
- "netmask": "255.255.255.0",
- "services": [
- "iscsi"
- ],
- "speed": 10000000000
- },
- "ct0.eth5": {
- "address": "10.10.10.14",
- "gateway": null,
- "hwaddr": "90:e2:ba:83:79:0d",
- "mtu": 1500,
- "netmask": "255.255.255.0",
- "services": [
- "iscsi"
- ],
- "speed": 10000000000
- },
- "vir0": {
- "address": "10.10.10.20",
- "gateway": "10.10.10.1",
- "hwaddr": "fe:ba:e9:e7:6b:0f",
- "mtu": 1500,
- "netmask": "255.255.255.0",
- "services": [
- "management"
- ],
- "speed": 1000000000
- }
- },
- "performance": {
- "input_per_sec": 8191,
- "output_per_sec": 0,
- "queue_depth": 1,
- "reads_per_sec": 0,
- "san_usec_per_write_op": 15,
- "usec_per_read_op": 0,
- "usec_per_write_op": 642,
- "writes_per_sec": 2
- },
- "pgroups": {
- "consisgroup-07b6b983-986e-46f5-bdc3-deaa3dbb299e-cinder": {
- "hgroups": null,
- "hosts": null,
- "source": "host1",
- "targets": null,
- "volumes": [
- "volume-1"
- ]
- }
- },
- "snapshots": {
- "consisgroup.cgsnapshot": {
- "created": "2018-03-28T09:34:02Z",
- "size": 13958643712,
- "source": "volume-1"
- }
- },
- "subnet": {},
- "volumes": {
- "ansible_data": {
- "hosts": [
- [
- "host1",
- 1
- ]
- ],
- "serial": "43BE47C12334399B000114A6",
- "size": 1099511627776
- }
+ {
+ "enabled": true,
+ "name": "user@acme.com"
+ }
+ ],
+ "snmp": [
+ {
+ "auth_passphrase": null,
+ "auth_protocol": null,
+ "community": null,
+ "host": "localhost",
+ "name": "localhost",
+ "privacy_passphrase": null,
+ "privacy_protocol": null,
+ "user": null,
+ "version": "v2c"
}
+ ],
+ "ssl_certs": {
+ "country": null,
+ "email": null,
+ "issued_by": "",
+ "issued_to": "",
+ "key_size": 2048,
+ "locality": null,
+ "organization": "Acme Storage, Inc.",
+ "organizational_unit": "Acme Storage, Inc.",
+ "state": null,
+ "status": "self-signed",
+ "valid_from": "2017-08-11T23:09:06Z",
+ "valid_to": "2027-08-09T23:09:06Z"
+ },
+ "syslog": []
+ }
+ "default": {
+ "array_name": "flasharray1",
+ "hostgroups": 0,
+ "hosts": 10,
+ "protection_groups": 1,
+ "purity_version": "5.0.4",
+ "snapshots": 1
+ }
+ "hgroups": {}
+ "hosts": {
+ "host1": {
+ "hgroup": null,
+ "iqn": [
+ "iqn.1994-05.com.redhat:2f6f5715a533"
+ ],
+ "wwn": []
+ },
+ "host2": {
+ "hgroup": null,
+ "iqn": [
+ "iqn.1994-05.com.redhat:d17fb13fe0b"
+ ],
+ "wwn": []
+ },
+ "host3": {
+ "hgroup": null,
+ "iqn": [
+ "iqn.1994-05.com.redhat:97b1351bfb2"
+ ],
+ "wwn": []
+ },
+ "host4": {
+ "hgroup": null,
+ "iqn": [
+ "iqn.1994-05.com.redhat:dd84e9a7b2cb"
+ ],
+ "wwn": [
+ "10000000C96C48D1",
+ "10000000C96C48D2"
+ ]
+ }
+ }
+ "interfaces": {
+ "CT0.ETH4": "iqn.2010-06.com.purestorage:flasharray.2111b767484e4682",
+ "CT0.ETH5": "iqn.2010-06.com.purestorage:flasharray.2111b767484e4682",
+ "CT1.ETH4": "iqn.2010-06.com.purestorage:flasharray.2111b767484e4682",
+ "CT1.ETH5": "iqn.2010-06.com.purestorage:flasharray.2111b767484e4682"
+ }
+ "network": {
+ "ct0.eth0": {
+ "address": "10.10.10.10",
+ "gateway": "10.10.10.1",
+ "hwaddr": "ec:f4:bb:c8:8a:04",
+ "mtu": 1500,
+ "netmask": "255.255.255.0",
+ "services": [
+ "management"
+ ],
+ "speed": 1000000000
+ },
+ "ct0.eth2": {
+ "address": "10.10.10.11",
+ "gateway": null,
+ "hwaddr": "ec:f4:bb:c8:8a:00",
+ "mtu": 1500,
+ "netmask": "255.255.255.0",
+ "services": [
+ "replication"
+ ],
+ "speed": 10000000000
+ },
+ "ct0.eth3": {
+ "address": "10.10.10.12",
+ "gateway": null,
+ "hwaddr": "ec:f4:bb:c8:8a:02",
+ "mtu": 1500,
+ "netmask": "255.255.255.0",
+ "services": [
+ "replication"
+ ],
+ "speed": 10000000000
+ },
+ "ct0.eth4": {
+ "address": "10.10.10.13",
+ "gateway": null,
+ "hwaddr": "90:e2:ba:83:79:0c",
+ "mtu": 1500,
+ "netmask": "255.255.255.0",
+ "services": [
+ "iscsi"
+ ],
+ "speed": 10000000000
+ },
+ "ct0.eth5": {
+ "address": "10.10.10.14",
+ "gateway": null,
+ "hwaddr": "90:e2:ba:83:79:0d",
+ "mtu": 1500,
+ "netmask": "255.255.255.0",
+ "services": [
+ "iscsi"
+ ],
+ "speed": 10000000000
+ },
+ "vir0": {
+ "address": "10.10.10.20",
+ "gateway": "10.10.10.1",
+ "hwaddr": "fe:ba:e9:e7:6b:0f",
+ "mtu": 1500,
+ "netmask": "255.255.255.0",
+ "services": [
+ "management"
+ ],
+ "speed": 1000000000
+ }
+ }
+ "performance": {
+ "input_per_sec": 8191,
+ "output_per_sec": 0,
+ "queue_depth": 1,
+ "reads_per_sec": 0,
+ "san_usec_per_write_op": 15,
+ "usec_per_read_op": 0,
+ "usec_per_write_op": 642,
+ "writes_per_sec": 2
+ }
+ "pgroups": {
+ "consisgroup-07b6b983-986e-46f5-bdc3-deaa3dbb299e-cinder": {
+ "hgroups": null,
+ "hosts": null,
+ "source": "host1",
+ "targets": null,
+ "volumes": [
+ "volume-1"
+ ]
+ }
+ }
+ "snapshots": {
+ "consisgroup.cgsnapshot": {
+ "created": "2018-03-28T09:34:02Z",
+ "size": 13958643712,
+ "source": "volume-1"
+ }
+ }
+ "subnet": {}
+ "volumes": {
+ "ansible_data": {
+ "hosts": [
+ [
+ "host1",
+ 1
+ ]
+ ],
+ "serial": "43BE47C12334399B000114A6",
+ "size": 1099511627776
+ }
+ }
'''
|
ansibot
added
community_review
ilicmilan
pushed a commit
to ilicmilan/ansible
that referenced
this pull request
Nov 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add new module to discover facts for a Pure Storage FlashArray.
Facts that can be discovered are:
- all
- minimum
- config
- performance
- capacity
- network
- subnet
- interfaces
- hgorups
- pgroups
- hosts
- volumes
- snapshots
ISSUE TYPE
COMPONENT NAME
module/storage/purestorage/purefa_facts
ANSIBLE VERSION
ADDITIONAL INFORMATION