Move AWS module placebo fixtures into test/units/utils #37300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
bug
bcoca
removed
the
needs_triage
ansibot
added
the
stale_ci
ryansb
approved these changes
Mar 22, 2018
|
rebuild_merge |
ansibot
removed
the
stale_ci
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Allows module_utils tests to use the placebo fixtures.
The recordings path is relative to the test. Module test recordings will remain in
test/units/modules/cloud/amazon/placebo_recordings/and module_utils tests will be added totest/units/module_utils/aws/placebo_recordings/. This will let me add some unit tests for #37212.ISSUE TYPE
COMPONENT NAME
test/units/utils/amazon_placebo_fixtures.py
ANSIBLE VERSION
ADDITIONAL INFORMATION