Fix junos modules check_mode issue #37311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ansible#37208 If check_mode is enabled instead of committing th config need to discard all the chnages to cnadidate db In case of cli to discard changes issue `rollback 0` command and for netconf execute `discard-changes` rpc call
ansibot
added
bug
ganeshrn
removed
the
needs_triage
ansibot
added
the
needs_revision
ansibot
removed
the
needs_revision
ansibot
added
the
stale_ci
ganeshrn
added a commit
to ganeshrn/ansible
that referenced
this pull request
Mar 26, 2018
Fixes ansible#37208 If check_mode is enabled instead of committing th config need to discard all the chnages to cnadidate db In case of cli to discard changes issue `rollback 0` command and for netconf execute `discard-changes` rpc call (cherry picked from commit 8eaa9cc)
|
Fix will be available in 2.5.1 |
ryancurrah
pushed a commit
to ryancurrah/ansible
that referenced
this pull request
Apr 4, 2018
Fixes ansible#37208 If check_mode is enabled instead of committing th config need to discard all the chnages to cnadidate db In case of cli to discard changes issue `rollback 0` command and for netconf execute `discard-changes` rpc call
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #37208
If check_mode is enabled instead of committing the config need to
discard all the changes to candidate db
In case of cli to discard changes issue
rollback 0commandand for netconf execute
discard-changesrpc callISSUE TYPE
COMPONENT NAME
module_utils/network/junos/junos.py
ANSIBLE VERSION
ADDITIONAL INFORMATION