Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win_setup: Added connection name to interfaces #37327

Merged
merged 1 commit into from
Apr 5, 2018
Merged

win_setup: Added connection name to interfaces #37327

merged 1 commit into from
Apr 5, 2018

Conversation

jborean93
Copy link
Contributor

SUMMARY

Adds the windows friendly name to the interface result. This makes it easier to determine what adapter the entry is for.

Fixes #37013

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

setup.ps1

ANSIBLE VERSION
2.6
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Mar 13, 2018

cc @dagwieers @jhawkesworth @nitzmahone
click here for bot help

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. windows Windows community labels Mar 13, 2018
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Mar 13, 2018
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. community_review In order to be merged, this PR must follow the community review workflow. labels Mar 13, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 23, 2018
@jborean93 jborean93 merged commit fd4d264 into ansible:devel Apr 5, 2018
@jborean93 jborean93 deleted the win_setup_netadapter-name branch April 5, 2018 21:36
jborean93 added a commit to jborean93/ansible that referenced this pull request Apr 5, 2018
@jborean93
win_setup: Added connection name to interfaces (ansible#37327)
b03ecfe 
(cherry picked from commit fd4d264)
@jborean93 jborean93 mentioned this pull request Apr 5, 2018
Merged
@jborean93
Copy link
Contributor Author

Backport PR for stable-2.5 #38362

jborean93 added a commit that referenced this pull request Apr 5, 2018
@jborean93
win_setup: backport Added connection name to interfaces (#38362)
ff03fc0 
* win_setup: Added connection name to interfaces (#37327)

(cherry picked from commit fd4d264)

* Added changelog fragment
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@jborean93 @ilicmilan
win_setup: Added connection name to interfaces (ansible#37327)
62ad986
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

interface name is not presented in windows facts
3 participants
@jborean93 @ansibot @bcoca