Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added module for Autoscale Launch Config #37345

Merged
merged 2 commits into from
Apr 5, 2018
Merged

Added module for Autoscale Launch Config #37345

merged 2 commits into from
Apr 5, 2018

Conversation

chaitanyaavi
Copy link
Contributor

@chaitanyaavi chaitanyaavi commented Mar 13, 2018 •
edited

SUMMARY

Added module for Autoscale Launch Config

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

network/avi/avi_autoscalelaunchconfig.py

ANSIBLE VERSION
ansible 2.6.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/vinay/git/avitest/local/lib/python2.7/site-packages/ansible
  executable location = /home/vinay/git/avitest/bin/ansible
  python version = 2.7.6 (default, Nov 23 2017, 15:49:48) [GCC 4.8.4]
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Mar 13, 2018

@ericsysmin @grastogi23 @khaltore

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Mar 13, 2018

cc @ericsysmin @grastogi23 @khaltore
click here for bot help

@ansibot ansibot added avi community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_contributor This PR is the first contribution by a new community member. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. labels Mar 13, 2018
@khaltore
Copy link

shipit

@grastogi23
Copy link
Contributor

@chaitanyaavi pl. update the module name and re-test with the ansible devel.

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Mar 13, 2018
resmo
resmo suggested changes Mar 13, 2018
View reviewed changes
lib/ansible/modules/network/avi/avi_autoscalelaunchconfig.py Outdated
description:
- Default method for object update is HTTP PUT.
- Setting to patch will override that behavior to use HTTP PATCH.
version_added: "2.5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove version added here

lib/ansible/modules/network/avi/avi_autoscalelaunchconfig.py Outdated
avi_api_patch_op:
description:
- Patch operation to use when using avi_api_update_method as patch.
version_added: "2.5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove version added here

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Mar 13, 2018
gundalow
gundalow reviewed Mar 16, 2018
View reviewed changes
lib/ansible/modules/network/avi/avi_autoscalelaunchconfig.py Outdated
DOCUMENTATION = '''
---
module: avi_autoscalelaunchconfig
author: Gaurav Rastogi (grastogi@avinetworks.com)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yourname here

@ansibot ansibot added needs_info This issue requires further information. Please answer any outstanding questions. and removed needs_info This issue requires further information. Please answer any outstanding questions. labels Mar 19, 2018
@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. and removed new_contributor This PR is the first contribution by a new community member. labels Mar 28, 2018
@grastogi23
Copy link
Contributor

@resmo @gundalow Can you pl. review and merge it. @chaitanyaavi has already fixed the review asks.

@gundalow gundalow merged commit f9bd29f into ansible:devel Apr 5, 2018
@gundalow
Copy link
Contributor

gundalow commented Apr 5, 2018

Merged into devel for release in Ansible 2.6.0

ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@ilicmilan
Added module for Autoscale Launch Config (ansible#37345)
c05a4fd 
* Added module for Autoscale Launch Config

* Fixed review comments
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@resmo resmo resmo requested changes

@gundalow gundalow gundalow approved these changes

Assignees
No one assigned
Labels
avi module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@chaitanyaavi @ansibot @khaltore @grastogi23 @gundalow @resmo @chaitanyadeshpande